From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com
Subject: Re: [PATCH v3 2/2] crypto: akcipher - Changes to asymmetric key API
Date: Thu, 1 Oct 2015 07:52:32 -0700 [thread overview]
Message-ID: <560D48B0.8090502@intel.com> (raw)
In-Reply-To: <20151001134536.GA27555@gondor.apana.org.au>
On 10/01/2015 06:45 AM, Herbert Xu wrote:
> On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
>>
>> struct akcipher_request {
>> struct crypto_async_request base;
>> - void *src;
>> - void *dst;
>> - unsigned int src_len;
>> - unsigned int dst_len;
>> + struct scatterlist *src;
>> + struct scatterlist *dst;
>> + unsigned int out_len;
>
> I think src_len/dst_len should be kept as the SG list may contain
> more entries than the ones that you need to process.
>
Herbert,
Could you still apply it and the "Add mpi sgl helpers" on top
and I'll add the src_len/dst_len in an incremental patch?
It will make it easier for me.
Thanks
next prev parent reply other threads:[~2015-10-01 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:33 [PATCH v3 0/2] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-09-22 16:33 ` [PATCH v3 1/2] lib/scatterlist: Add sg_len helper Tadeusz Struk
2015-09-22 16:34 ` [PATCH v3 2/2] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-10-01 13:45 ` Herbert Xu
2015-10-01 14:52 ` Tadeusz Struk [this message]
2015-10-01 15:15 ` Herbert Xu
2015-10-01 15:17 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D48B0.8090502@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).