From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tadeusz Struk Subject: Re: [PATCH v3 2/2] crypto: akcipher - Changes to asymmetric key API Date: Thu, 1 Oct 2015 07:52:32 -0700 Message-ID: <560D48B0.8090502@intel.com> References: <20150922163352.18101.85685.stgit@tstruk-mobl1> <20150922163403.18101.92452.stgit@tstruk-mobl1> <20151001134536.GA27555@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com To: Herbert Xu Return-path: Received: from mga02.intel.com ([134.134.136.20]:4387 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754203AbbJAOzE (ORCPT ); Thu, 1 Oct 2015 10:55:04 -0400 In-Reply-To: <20151001134536.GA27555@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 10/01/2015 06:45 AM, Herbert Xu wrote: > On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote: >> >> struct akcipher_request { >> struct crypto_async_request base; >> - void *src; >> - void *dst; >> - unsigned int src_len; >> - unsigned int dst_len; >> + struct scatterlist *src; >> + struct scatterlist *dst; >> + unsigned int out_len; > > I think src_len/dst_len should be kept as the SG list may contain > more entries than the ones that you need to process. > Herbert, Could you still apply it and the "Add mpi sgl helpers" on top and I'll add the src_len/dst_len in an incremental patch? It will make it easier for me. Thanks