From: Zain <zain.wang@rock-chips.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: zhengsq@rock-chips.com, hl@rock-chips.com, davem@davemloft.net,
mturquette@baylibre.com, heiko@sntech.de, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
galak@codeaurora.org, linux@arm.linux.org.uk,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, eddie.cai@rock-chips.com
Subject: Re: [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288
Date: Tue, 24 Nov 2015 08:48:54 +0800 [thread overview]
Message-ID: <5653B3F6.9080006@rock-chips.com> (raw)
In-Reply-To: <20151123125142.GA7709@gondor.apana.org.au>
On 2015年11月23日 20:51, Herbert Xu wrote:
> On Tue, Nov 17, 2015 at 12:00:46PM +0800, Zain Wang wrote:
>> +static void rk_ablk_hw_init(struct rk_crypto_info *dev)
>> +{
>> + struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(dev->ablk_req);
>> + struct rk_cipher_ctx *ctx = crypto_ablkcipher_ctx(tfm);
>> + u32 conf_reg = 0;
>> +
>> + if (dev->mode & TDES) {
>> + dev->mode &= ~TDES;
>> + dev->mode |= RK_CRYPTO_TDES_FIFO_MODE |
>> + RK_CRYPTO_TDES_BYTESWAP_KEY |
>> + RK_CRYPTO_TDES_BYTESWAP_IV;
>> + CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, dev->mode);
>> +
>> + memcpy(dev->reg + RK_CRYPTO_TDES_IV_0, dev->ablk_req->info, 8);
> Please ensure that the IV is copied back after the operation.
> I know that many existing drivers are buggy in this regard but
> they will be fixed soon and we will start enforcing this rule
> so I don't want to add any new drivers that break this rule.
Thanks your responding, I will fix it in v5.
>
> Thanks,
next prev parent reply other threads:[~2015-11-24 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 4:00 [PATCH v4 0/4] crypto: add crypto accelerator support for rk3288 Zain Wang
2015-11-17 4:00 ` [PATCH v4 1/4] crypto: rockchip/crypto - add DT bindings documentation Zain Wang
[not found] ` <1447732847-30514-1-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-17 4:00 ` [PATCH v4 2/4] clk: rockchip: set an ID for crypto clk Zain Wang
[not found] ` <1447732847-30514-3-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-23 23:24 ` Heiko Stübner
2015-11-24 0:49 ` Zain
2015-11-17 4:00 ` [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288 Zain Wang
2015-11-23 12:51 ` Herbert Xu
2015-11-24 0:48 ` Zain [this message]
2015-11-17 4:00 ` [PATCH v4 4/4] ARM: dts: rockchip: Add Crypto node " Zain Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653B3F6.9080006@rock-chips.com \
--to=zain.wang@rock-chips.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=hl@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).