From: "Horia Geantă" <horia.geanta@freescale.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>,
Fabio Estevam <fabio.estevam@freescale.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH RFC 06/11] crypto: caam: ensure that we clean up after an error
Date: Wed, 9 Dec 2015 17:08:41 +0200 [thread overview]
Message-ID: <566843F9.6000508@freescale.com> (raw)
In-Reply-To: <E1a61Cz-0007mm-QP@rmk-PC.arm.linux.org.uk>
On 12/7/2015 9:12 PM, Russell King wrote:
> Ensure that we clean up allocations and DMA mappings after encountering
> an error rather than just giving up and leaking memory and resources.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
I guess the error cleanup code should be grouped under an "err" label,
instead of duplicating it.
Horia
next prev parent reply other threads:[~2015-12-09 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 19:11 [PATCH RFC 00/13] Further iMX CAAM updates Russell King - ARM Linux
2015-12-07 19:12 ` [PATCH RFC 01/11] crypto: caam: fix DMA API mapping leak Russell King
2015-12-07 19:12 ` [PATCH RFC 02/11] crypto: caam: ensure descriptor buffers are cacheline aligned Russell King
2015-12-07 19:12 ` [PATCH RFC 03/11] crypto: caam: incorporate job descriptor into struct ahash_edesc Russell King
2015-12-07 19:12 ` [PATCH RFC 04/11] crypto: caam: mark the hardware descriptor as cache line aligned Russell King
2015-12-07 19:12 ` [PATCH RFC 05/11] crypto: caam: replace sec4_sg pointer with array Russell King
2015-12-07 19:12 ` [PATCH RFC 06/11] crypto: caam: ensure that we clean up after an error Russell King
2015-12-09 15:08 ` Horia Geantă [this message]
2015-12-09 18:30 ` Russell King - ARM Linux
2015-12-07 19:12 ` [PATCH RFC 07/11] crypto: caam: check and use dma_map_sg() return code Russell King
2015-12-09 15:20 ` Horia Geantă
2015-12-09 18:31 ` Russell King - ARM Linux
2015-12-07 19:12 ` [PATCH RFC 08/11] crypto: caam: add ahash_edesc_alloc() for descriptor allocation Russell King
2015-12-07 19:12 ` [PATCH RFC 09/11] crypto: caam: move job descriptor initialisation to ahash_edesc_alloc() Russell King
2015-12-07 19:12 ` [PATCH RFC 10/11] crypto: caam: add ahash_edesc_add_src() Russell King
2015-12-09 16:21 ` Horia Geantă
2015-12-07 19:12 ` [PATCH RFC 11/11] crypto: caam: get rid of tasklet Russell King
2015-12-07 20:59 ` [PATCH RFC 00/13] Further iMX CAAM updates Fabio Estevam
2015-12-09 15:06 ` Horia Geantă
2015-12-09 18:21 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566843F9.6000508@freescale.com \
--to=horia.geanta@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).