* [PATCH] crypto: qat - update init_esram for C3xxx dev type
@ 2016-01-08 18:19 Tadeusz Struk
2016-01-08 18:35 ` Tadeusz Struk
2016-01-15 18:29 ` Tadeusz Struk
0 siblings, 2 replies; 4+ messages in thread
From: Tadeusz Struk @ 2016-01-08 18:19 UTC (permalink / raw)
To: herbert; +Cc: tadeusz.struk, pingchao.yang, linux-crypto
There is no esram on C3xxx devices so we don't need to wait for
it to initialize.
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
drivers/crypto/qat/qat_common/qat_hal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
index 7786e6e..daecd71 100644
--- a/drivers/crypto/qat/qat_common/qat_hal.c
+++ b/drivers/crypto/qat/qat_common/qat_hal.c
@@ -456,6 +456,9 @@ static int qat_hal_init_esram(struct icp_qat_fw_loader_handle *handle)
unsigned int csr_val;
int times = 30;
+ if (handle->pci_dev->device == ADF_C3XXX_PCI_DEVICE_ID)
+ return 0;
+
csr_val = ADF_CSR_RD(csr_addr, 0);
if ((csr_val & ESRAM_AUTO_TINIT) && (csr_val & ESRAM_AUTO_TINIT_DONE))
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: qat - update init_esram for C3xxx dev type
2016-01-08 18:19 [PATCH] crypto: qat - update init_esram for C3xxx dev type Tadeusz Struk
@ 2016-01-08 18:35 ` Tadeusz Struk
2016-01-15 18:29 ` Tadeusz Struk
1 sibling, 0 replies; 4+ messages in thread
From: Tadeusz Struk @ 2016-01-08 18:35 UTC (permalink / raw)
To: herbert; +Cc: pingchao.yang, linux-crypto
On 01/08/2016 10:19 AM, Tadeusz Struk wrote:
> There is no esram on C3xxx devices so we don't need to wait for
> it to initialize.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
> drivers/crypto/qat/qat_common/qat_hal.c | 3 +++
> 1 file changed, 3 insertions(+)
Hi Herbert,
This one is generated on top of Pingchao's patch "crypto: qat - fix timeout issues"
https://patchwork.kernel.org/patch/7972981/
Thanks
--
TS
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: crypto: qat - update init_esram for C3xxx dev type
2016-01-08 18:19 [PATCH] crypto: qat - update init_esram for C3xxx dev type Tadeusz Struk
2016-01-08 18:35 ` Tadeusz Struk
@ 2016-01-15 18:29 ` Tadeusz Struk
2016-01-18 15:23 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Tadeusz Struk @ 2016-01-15 18:29 UTC (permalink / raw)
To: herbert; +Cc: pingchao.yang, linux-crypto
On 01/08/2016 10:19 AM, Tadeusz Struk wrote:
> There is no esram on C3xxx devices so we don't need to wait for
> it to initialize.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
>
> ---
> drivers/crypto/qat/qat_common/qat_hal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
> index 7786e6e..daecd71 100644
> --- a/drivers/crypto/qat/qat_common/qat_hal.c
> +++ b/drivers/crypto/qat/qat_common/qat_hal.c
> @@ -456,6 +456,9 @@ static int qat_hal_init_esram(struct icp_qat_fw_loader_handle *handle)
> unsigned int csr_val;
> int times = 30;
>
> + if (handle->pci_dev->device == ADF_C3XXX_PCI_DEVICE_ID)
> + return 0;
> +
> csr_val = ADF_CSR_RD(csr_addr, 0);
> if ((csr_val & ESRAM_AUTO_TINIT) && (csr_val & ESRAM_AUTO_TINIT_DONE))
> return 0;
>
Herbert,
This fixes another BAR related issue on C3XXX device, which prevents
C3XXX device from being initialized. Please include this fix into 4.5.
The patch is created on top of the "[V3] crypto: qat - fix timeout issues"
Thanks,
--
TS
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: crypto: qat - update init_esram for C3xxx dev type
2016-01-15 18:29 ` Tadeusz Struk
@ 2016-01-18 15:23 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-01-18 15:23 UTC (permalink / raw)
To: Tadeusz Struk; +Cc: pingchao.yang, linux-crypto
On Fri, Jan 15, 2016 at 10:29:12AM -0800, Tadeusz Struk wrote:
> On 01/08/2016 10:19 AM, Tadeusz Struk wrote:
> > There is no esram on C3xxx devices so we don't need to wait for
> > it to initialize.
> >
> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-18 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 18:19 [PATCH] crypto: qat - update init_esram for C3xxx dev type Tadeusz Struk
2016-01-08 18:35 ` Tadeusz Struk
2016-01-15 18:29 ` Tadeusz Struk
2016-01-18 15:23 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).