From: Mark McKinstry <Mark.McKinstry@alliedtelesis.co.nz>
To: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "alexander.h.duyck@redhat.com" <alexander.h.duyck@redhat.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: [PATCH] vti6: Add pmtu handling to vti6_xmit.
Date: Wed, 10 Feb 2016 01:50:20 +0000 [thread overview]
Message-ID: <56BA975D.2040706@alliedtelesis.co.nz> (raw)
In-Reply-To: <20150529182709.2147.78230.stgit@ahduyck-vm-fedora22>
http://www.spinics.net/lists/linux-crypto/msg15101.html
> From: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
>
> We currently rely on the PMTU discovery of xfrm.
> However if a packet is localy sent, the PMTU mechanism
> of xfrm tries to to local socket notification what
> might not work for applications like ping that don't
> check for this. So add pmtu handling to vti6_xmit to
> report MTU changes immediately.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxx>
> ---
>
> So this version is slightly modified to cover the IPv4 case in addition to
> the IPv6 case. With this patch I was able to run netperf over either an
> IPv4 or IPv6 address routed over the ip6_vti tunnel.
We have the same issue. When we do a local ping to a remote device over
a v4 vti tunnel and an intermediate device has a low mtu, pmtu
discovery reduces the route's pmtu, and ping fails because it does not
handle the local error message generated by xfrm4_tunnel_check_size().
Your patch fixes our issue for v6 vti tunnels, but the issue still
exists for v4 tunnels. Is there any particular reason this patch was
not delivered for v4 tunnels too - i.e. in vti_xmit()?
next prev parent reply other threads:[~2016-02-10 1:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 17:40 [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels Alexander Duyck
2015-05-28 4:49 ` Herbert Xu
2015-05-28 4:56 ` Steffen Klassert
2015-05-28 5:36 ` Steffen Klassert
2015-05-28 7:18 ` Alexander Duyck
2015-05-28 8:40 ` Steffen Klassert
2015-05-28 19:15 ` Alexander Duyck
2015-05-29 16:53 ` Alexander Duyck
2015-05-29 18:28 ` [PATCH] vti6: Add pmtu handling to vti6_xmit Alexander Duyck
2015-06-01 23:04 ` David Miller
2016-02-10 1:50 ` Mark McKinstry [this message]
2016-02-17 7:08 ` Steffen Klassert
2016-02-18 1:40 ` Mark McKinstry
2016-02-18 12:19 ` Steffen Klassert
2016-02-24 21:37 ` Mark McKinstry
2016-02-25 11:21 ` Steffen Klassert
2016-03-04 7:05 ` Steffen Klassert
2016-03-14 21:52 ` Mark McKinstry
2016-03-15 12:28 ` Steffen Klassert
2016-03-22 10:53 ` Steffen Klassert
2016-03-30 21:04 ` Mark McKinstry
2016-04-01 8:08 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA975D.2040706@alliedtelesis.co.nz \
--to=mark.mckinstry@alliedtelesis.co.nz \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).