From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Tudor Ambarus <tudor-dan.ambarus@nxp.com>, herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, smueller@chronox.de, horia.geanta@nxp.com
Subject: Re: [PATCH 07/10] crypto: qat - remove duplicate ASN.1 parser
Date: Sun, 20 Mar 2016 07:55:36 -0700 [thread overview]
Message-ID: <56EEB9E8.3070808@intel.com> (raw)
In-Reply-To: <1458325927-14737-7-git-send-email-tudor-dan.ambarus@nxp.com>
On 03/18/2016 11:32 AM, Tudor Ambarus wrote:
> Use the RSA's software implementation parser with
> raw integer actions.
>
> Compile-tested only.
>
> Signed-off-by: Tudor Ambarus <tudor-dan.ambarus@nxp.com>
> ---
> drivers/crypto/qat/Kconfig | 3 +-
> drivers/crypto/qat/qat_common/Makefile | 10 +-
> drivers/crypto/qat/qat_common/qat_asym_algs.c | 265 +++++++---------------
> drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1 | 11 -
> drivers/crypto/qat/qat_common/qat_rsapubkey.asn1 | 4 -
> 5 files changed, 83 insertions(+), 210 deletions(-)
> delete mode 100644 drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1
> delete mode 100644 drivers/crypto/qat/qat_common/qat_rsapubkey.asn1
Thanks for converting qat, but I'm working on adding support for the Chinese
remainder algorithm, which gives us big performance improvement, so please
do not change the qat driver just yet.
Please just add a generic ANS.1 parser that would allow to obtain all
components of the private key and I'll use it to add the handlers
and remove the ASN.1 parsing from qat. I will then test it to make sure
that it works fine before it is committed.
Thanks,
--
TS
next prev parent reply other threads:[~2016-03-20 15:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 18:31 [PATCH 01/10] crypto: rsa - generalize ASN.1 sequences Tudor Ambarus
2016-03-18 18:31 ` [PATCH 02/10] crypto: rsa_helper - add raw integer parser actions Tudor Ambarus
2016-03-18 19:46 ` Stephan Mueller
2016-03-21 15:17 ` Tudor-Dan Ambarus
2016-03-21 19:14 ` Stephan Mueller
2016-03-18 18:32 ` [PATCH 03/10] crypto: add CONFIG_ symbol for rsa helper Tudor Ambarus
2016-03-18 18:32 ` [PATCH 04/10] crypto: rsa_helper - export symbols for asn1 structures Tudor Ambarus
2016-03-18 18:32 ` [PATCH 05/10] crypto: qat - avoid memory corruption or undefined behaviour Tudor Ambarus
2016-03-18 18:32 ` [PATCH 06/10] crypto: qat - fix address leaking of RSA public exponent Tudor Ambarus
2016-03-18 18:32 ` [PATCH 07/10] crypto: qat - remove duplicate ASN.1 parser Tudor Ambarus
2016-03-20 14:55 ` Tadeusz Struk [this message]
2016-03-21 10:12 ` Tudor-Dan Ambarus
2016-03-18 18:32 ` [PATCH 08/10] crypto: scatterwak - Add scatterwalk_sg_copychunks Tudor Ambarus
2016-03-18 19:52 ` Stephan Mueller
2016-03-18 18:32 ` [PATCH 09/10] crypto: scatterwalk - export scatterwalk_pagedone Tudor Ambarus
2016-03-18 18:32 ` [PATCH 10/10] crypto: caam - add support for RSA algorithm Tudor Ambarus
2016-03-19 16:59 ` Stephan Mueller
2016-03-21 11:07 ` Tudor-Dan Ambarus
2016-03-20 14:53 ` [PATCH 01/10] crypto: rsa - generalize ASN.1 sequences Tadeusz Struk
2016-03-21 10:11 ` Tudor-Dan Ambarus
2016-03-21 15:24 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EEB9E8.3070808@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
--cc=tudor-dan.ambarus@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).