From: Gary R Hook <ghook@amd.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Denis B <begun.denis@gmail.com>, <linux-crypto@vger.kernel.org>
Subject: Re: IV generation in cryptographic driver in AEAD
Date: Mon, 23 May 2016 08:27:38 -0500 [thread overview]
Message-ID: <5743054A.3010009@amd.com> (raw)
In-Reply-To: <20160520233132.GA18006@gondor.apana.org.au>
On 05/20/2016 06:31 PM, Herbert Xu wrote:
> On Fri, May 20, 2016 at 10:50:38AM -0500, Gary R Hook wrote:
>>
>> Why is (or should) setting geniv (be) required?
>>
>> crypto_givcipher_default() appears to call crypto_default_geniv() if
>> the geniv member
>> is NULL. That function returns "eseqiv" or "chainiv" (under certain
>> conditions). If an
>> implementation isn't generating its own IVs, shouldn't the default
>> happen anyway? Or is
>> this more a matter of populating the structure with known,
>> intentional values?
>>
>> Thank you for any illumination provided.
>
> In the upstream kernel AEAD geniv has been completely phased out
> and no longer exists. Denis is working on an old kernel that still
> has it.
>
> We haven't yet phased it out for skcipher but I'm working on it.
...and there was light.
Thank you; very helpful.
(I'll work harder on my line wraps... If someone knows how to get
Thunderbird
to do it for me, I'd love to know.)
next prev parent reply other threads:[~2016-05-23 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:06 IV generation in cryptographic driver in AEAD Denis B
2016-05-18 13:56 ` Catalin Vasile
2016-05-18 14:21 ` Denis B
2016-05-19 2:43 ` Herbert Xu
2016-05-19 6:44 ` Catalin Vasile
2016-05-19 11:05 ` Denis B
2016-05-20 4:19 ` Herbert Xu
2016-05-20 15:50 ` Gary R Hook
2016-05-20 23:31 ` Herbert Xu
2016-05-23 13:27 ` Gary R Hook [this message]
2016-05-18 17:58 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743054A.3010009@amd.com \
--to=ghook@amd.com \
--cc=begun.denis@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).