Re: [RFC] MAINTAINERS tag for cleanup robot

Tom Rix
2020-11-22T16:33:41Z

On 11/21/20 9:10 AM, Joe Perches wrote:
> On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote:
>> A difficult part of automating commits is composing the subsystem
>> preamble in the commit log. For the ongoing effort of a fixer producing
>> one or two fixes a release the use of 'treewide:' does not seem appropriate.
>>
>> It would be better if the normal prefix was used. Unfortunately normal is
>> not consistent across the tree.
>>
>> So I am looking for comments for adding a new tag to the MAINTAINERS file
>>
>> D: Commit subsystem prefix
>>
>> ex/ for FPGA DFL DRIVERS
>>
>> D: fpga: dfl:
> I'm all for it. Good luck with the effort. It's not completely trivial.
>
> From a decade ago:
>
> https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/
>
> (and that thread started with extra semicolon patches too)

Reading the history, how about this.

get_mataintainer.pl outputs a single prefix, if multiple files have the same prefix it works, if they don't its an error.

Another script 'commit_one_file.sh' does the call to get_mainainter.pl to get the prefix and be called by run-clang-tools.py to get the fixer specific message.

Defer minimizing the commits by combining similar subsystems till later.

In a steady state case, this should be uncommon.

>
>> Continuing with cleaning up clang's -Wextra-semi-stmt
>> diff --git a/Makefile b/Makefile
> []
>> @@ -1567,20 +1567,21 @@ help:
>>   echo ''
>>   @echo 'Static analysers:'
>>   @echo ' checkstack - Generate a list of stack hogs'
>>   @echo ' versioncheck - Sanity check on version.h usage'
>>   @echo ' includecheck - Check for duplicate included header files'
>>   @echo ' export_report - List the usages of all exported symbols'
>>   @echo ' headerdep - Detect inclusion cycles in headers'
>>   @echo ' coccicheck - Check with Coccinelle'
>>   @echo ' clang-analyzer - Check with clang static analyzer'
>>   @echo ' clang-tidy - Check with clang-tidy'
>> + @echo ' clang-tidy-fix - Check and fix with clang-tidy'
> A pity the ordering of the code below isn't the same as the above.

Taken care thanks!

Tom