From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Mahipal Challa <mahipalreddy2006@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jan Glauber <jglauber@cavium.com>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] crypto: zip - Memory corruption in zip_clear_stats()
Date: Sat, 18 Mar 2017 11:24:34 +0100 [thread overview]
Message-ID: <58CD0AE2.3070006@bfs.de> (raw)
In-Reply-To: <20170317204621.GD16505@mwanda>
Am 17.03.2017 21:46, schrieb Dan Carpenter:
> There is a typo here. It should be "stats" instead of "state". The
> impact is that we clear 224 bytes instead of 80 and we zero out memory
> that we shouldn't.
>
> Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/crypto/cavium/zip/zip_main.c b/drivers/crypto/cavium/zip/zip_main.c
> index 0951e20b395b..6ff13d80d82e 100644
> --- a/drivers/crypto/cavium/zip/zip_main.c
> +++ b/drivers/crypto/cavium/zip/zip_main.c
> @@ -530,7 +530,7 @@ static int zip_clear_stats(struct seq_file *s, void *unused)
> for (index = 0; index < MAX_ZIP_DEVICES; index++) {
> if (zip_dev[index]) {
> memset(&zip_dev[index]->stats, 0,
> - sizeof(struct zip_state));
> + sizeof(struct zip_stats));
as future FIXME some show find a name that differ in more than just the last char.
NTL maybe
sizeof(zip_dev[index]->stats)
can be used here ?
re,
wh
> seq_printf(s, "Cleared stats for zip %d\n", index);
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-03-18 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 20:46 [PATCH] crypto: zip - Memory corruption in zip_clear_stats() Dan Carpenter
2017-03-18 10:24 ` walter harms [this message]
2017-03-18 10:59 ` Dan Carpenter
2017-03-20 14:22 ` Mahipal Reddy
2017-03-24 14:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58CD0AE2.3070006@bfs.de \
--to=wharms@bfs.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jglauber@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mahipalreddy2006@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).