From: Zhou Wang <wangzhou1@hisilicon.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, <linux-crypto@vger.kernel.org>
Subject: Re: [v3 PATCH] crypto: hisilicon - Fix warning on printing %p with dma_addr_t
Date: Fri, 16 Aug 2019 14:04:07 +0800 [thread overview]
Message-ID: <5D564757.5040009@hisilicon.com> (raw)
In-Reply-To: <20190815224743.GA3261@gondor.apana.org.au>
On 2019/8/16 6:47, Herbert Xu wrote:
> This patch fixes a printk format warning by replacing %p with %#llx
> for dma_addr_t.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index d72e062..4ad4de4 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -347,8 +353,8 @@ static int qm_mb(struct hisi_qm *qm, u8 cmd, dma_addr_t dma_addr, u16 queue,
> struct qm_mailbox mailbox;
> int ret = 0;
>
> - dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%pad\n", queue,
> - cmd, dma_addr);
> + dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%llx\n",
> + queue, cmd, (unsigned long long)dma_addr);
I should modify this as:
dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%pad\n",
queue, cmd, &dma_addr);
>
> mailbox.w0 = cmd |
> (op ? 0x1 << QM_MB_OP_SHIFT : 0) |
>
prev parent reply other threads:[~2019-08-16 6:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:03 crypto: hisilicon - Fix warning on printing %p with dma_addr_t Herbert Xu
2019-08-15 14:17 ` Zhou Wang
2019-08-15 22:42 ` Herbert Xu
2019-08-16 7:02 ` Ondrej Mosnáček
2019-08-16 7:08 ` Ondrej Mosnáček
2019-08-16 7:53 ` Zhou Wang
2019-08-15 22:45 ` [v2 PATCH] " Herbert Xu
2019-08-15 22:47 ` [v3 " Herbert Xu
2019-08-16 6:04 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D564757.5040009@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).