From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADD4C3A5AB for ; Thu, 5 Sep 2019 06:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC31321743 for ; Thu, 5 Sep 2019 06:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731542AbfIEGZc (ORCPT ); Thu, 5 Sep 2019 02:25:32 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42094 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731359AbfIEGZc (ORCPT ); Thu, 5 Sep 2019 02:25:32 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 81238E957918129EA04E; Thu, 5 Sep 2019 14:25:30 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Thu, 5 Sep 2019 14:25:28 +0800 Message-ID: <5D70AA57.5080700@huawei.com> Date: Thu, 5 Sep 2019 14:25:27 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Will Deacon , CC: , , , , Subject: Re: [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation. References: <1567493656-19916-1-git-send-email-zhongjiang@huawei.com> <20190904102526.5vtdv5ofuezn7fre@willie-the-truck> In-Reply-To: <20190904102526.5vtdv5ofuezn7fre@willie-the-truck> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2019/9/4 18:25, Will Deacon wrote: > On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote: >> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to >> use it directly. hence just replace it. >> >> Signed-off-by: zhong jiang >> --- >> arch/arm64/crypto/aes-glue.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c >> index ca0c84d..2a2e0a3 100644 >> --- a/arch/arm64/crypto/aes-glue.c >> +++ b/arch/arm64/crypto/aes-glue.c >> @@ -409,10 +409,8 @@ static int essiv_cbc_init_tfm(struct crypto_skcipher *tfm) >> struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm); >> >> ctx->hash = crypto_alloc_shash("sha256", 0, 0); >> - if (IS_ERR(ctx->hash)) >> - return PTR_ERR(ctx->hash); >> >> - return 0; >> + return PTR_ERR_OR_ZERO(ctx->hash); >> } >> >> static void essiv_cbc_exit_tfm(struct crypto_skcipher *tfm) > Acked-by: Will Deacon Thanks. Sincerely, zhong jiang > Assuming this will go via Herbert. > > Will > > . >