Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Gary R Hook <ghook@amd.com>
To: Eric Biggers <ebiggers@kernel.org>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"Hook, Gary" <Gary.Hook@amd.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Cfir Cohen <cfir@google.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: gcm-aes-ccp self-tests failure
Date: Tue, 2 Jul 2019 17:44:55 +0000	[thread overview]
Message-ID: <5aa874b3-22ad-3fc1-687c-9e02e0bd60e9@amd.com> (raw)
In-Reply-To: <20190702160614.GC895@sol.localdomain>

On 7/2/19 11:06 AM, Eric Biggers wrote:
> Hi Tom and Gary,
> 
> On latest cryptodev tree, I'm seeing the following self-test failure after I
> built a kernel with the AMD CCP driver and crypto self-tests enabled, and booted
> it on system with a Ryzen processor ("Threadripper 1950X"):
> 
> [    4.378985] alg: aead: gcm-aes-ccp encryption test failed (wrong result) on test vector 2, cfg="two even aligned splits"
> 
> i.e., in some cases the AES-GCM implementation produces the wrong ciphertext
> and/or authentication tag.
> 
> Is this is a known issue?  When will it be fixed?
> 
> The potentially relevant bits of my Kconfig are:
> 
> 	CONFIG_CRYPTO_AES=y
> 	CONFIG_CRYPTO_GCM=y
> 	CONFIG_CRYPTO_DEV_CCP=y
> 	CONFIG_CRYPTO_DEV_CCP_DD=y
> 	CONFIG_CRYPTO_DEV_SP_CCP=y
> 	CONFIG_CRYPTO_DEV_CCP_CRYPTO=y
> 	CONFIG_CRYPTO_DEV_SP_PSP=y
> 	# CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
> 	CONFIG_DEBUG_KERNEL=y
> 	CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
> 
> - Eric
> 

Yes, this is a known problem. We have no estimate on a fix at this time. 
I need to light a fire under someone now.

grh

      reply	other threads:[~2019-07-02 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 16:06 gcm-aes-ccp self-tests failure Eric Biggers
2019-07-02 17:44 ` Gary R Hook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5aa874b3-22ad-3fc1-687c-9e02e0bd60e9@amd.com \
    --to=ghook@amd.com \
    --cc=Gary.Hook@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=cfir@google.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox