Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

Herbert Xu
2025-05-10T09:05:42Z

On Sat, May 10, 2025 at 10:32:53AM +0200, Klaus Kudielka wrote:
>
> So, I am back at the hardware (armada-385-turris-omnia), and gave this patch a try.
> CONFIG_CRYPTO_DEV_MARVELL_CESA=m
>
> Upon modprobe marvell-cesa, I get the following results.

Thanks, could you please try this patch which goes on top of the
previous v3 patch to disable chaining completely?

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/drivers/crypto/marvell/cesa/tdma.c b/drivers/crypto/marvell/cesa/tdma.c
index 9b5fd957dde2..f4fe2a881f1e 100644
--- a/drivers/crypto/marvell/cesa/tdma.c
+++ b/drivers/crypto/marvell/cesa/tdma.c
@@ -123,7 +123,7 @@ void mv_cesa_tdma_chain(struct mv_cesa_engine *engine,
* Break the DMA chain if the CESA_TDMA_BREAK_CHAIN is set on
* the last element of the current chain.
*/
- if (last->flags & CESA_TDMA_BREAK_CHAIN) {
+ if (1 || (last->flags & CESA_TDMA_BREAK_CHAIN)) {
engine->chain_sw.first = NULL;
engine->chain_sw.last = NULL;
}