Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

Klaus Kudielka
2025-05-10T09:38:18Z

On Sat, 2025-05-10 at 17:05 +0800, Herbert Xu wrote:
> On Sat, May 10, 2025 at 10:32:53AM +0200, Klaus Kudielka wrote:
> >
> > So, I am back at the hardware (armada-385-turris-omnia), and gave this patch a try.
> > CONFIG_CRYPTO_DEV_MARVELL_CESA=m
> >
> > Upon modprobe marvell-cesa, I get the following results.
>
> Thanks, could you please try this patch which goes on top of the
> previous v3 patch to disable chaining completely?
>
> Thanks,

Patch applied on top.
On the first attempt all self-tests passed, but on the second and third unfortunately not.

[ 16.841981] marvell-cesa f1090000.crypto: CESA device successfully registered
[ 16.912258] alg: ahash: mv-sha256 test failed (wrong result) on test vector 2, cfg="import/export"
[ 16.917574] alg: ahash: mv-md5 test failed (wrong result) on test vector 3, cfg="init+update+final misaligned buffer"
[ 16.921323] alg: self-tests for sha256 using mv-sha256 failed (rc=-22)
[ 16.931961] ------------[ cut here ]------------
[ 16.931966] WARNING: CPU: 1 PID: 388 at crypto/testmgr.c:5871 alg_test+0x5f0/0x614
[ 16.931982] alg: self-tests for sha256 using mv-sha256 failed (rc=-22)
[ 16.931985] Modules linked in:
[ 16.931984] alg: self-tests for md5 using mv-md5 failed (rc=-22)
[ 16.931989] ------------[ cut here ]------------
[ 16.931989] marvell_cesa libdes libaes
[ 16.931993] WARNING: CPU: 0 PID: 386 at crypto/testmgr.c:5871 alg_test+0x5f0/0x614
[ 16.932001] CPU: 1 UID: 0 PID: 388 Comm: cryptomgr_test Not tainted 6.15.0-rc5+ #5 NONE
[ 16.932004] alg: self-tests for md5 using mv-md5 failed (rc=-22)
[ 16.932007] Modules linked in:
[ 16.932009] Hardware name: Marvell Armada 380/385 (Device Tree)
[ 16.932012] marvell_cesa
[ 16.932013] Call trace:
[ 16.932015] libdes libaes
[ 16.932018] unwind_backtrace from show_stack+0x10/0x14
[ 16.932033] show_stack from dump_stack_lvl+0x50/0x64
[ 16.932042] dump_stack_lvl from __warn+0x7c/0xd4
[ 16.932052] __warn from warn_slowpath_fmt+0x110/0x16c
[ 16.932063] warn_slowpath_fmt from alg_test+0x5f0/0x614
[ 16.932073] alg_test from cryptomgr_test+0x18/0x38
[ 16.932080] cryptomgr_test from kthread+0xe8/0x204
[ 16.932090] kthread from ret_from_fork+0x14/0x28
[ 16.932097] Exception stack(0xf0aadfb0 to 0xf0aadff8)
[ 16.932102] dfa0: 00000000 00000000 00000000 00000000
[ 16.932107] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 16.932112] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 16.932115] ---[ end trace 0000000000000000 ]---
[ 16.932115] CPU: 0 UID: 0 PID: 386 Comm: cryptomgr_test Not tainted 6.15.0-rc5+ #5 NONE
[ 16.932122] Hardware name: Marvell Armada 380/385 (Device Tree)
[ 16.932125] Call trace:
[ 16.932127] unwind_backtrace from show_stack+0x10/0x14
[ 16.932139] show_stack from dump_stack_lvl+0x50/0x64
[ 16.932148] dump_stack_lvl from __warn+0x7c/0xd4
[ 16.932157] __warn from warn_slowpath_fmt+0x110/0x16c
[ 16.932168] warn_slowpath_fmt from alg_test+0x5f0/0x614
[ 16.932178] alg_test from cryptomgr_test+0x18/0x38
[ 16.932185] cryptomgr_test from kthread+0xe8/0x204
[ 16.932193] kthread from ret_from_fork+0x14/0x28
[ 16.932200] Exception stack(0xf0aa1fb0 to 0xf0aa1ff8)
[ 16.932205] 1fa0: 00000000 00000000 00000000 00000000
[ 16.932210] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 16.932214] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 16.932217] ---[ end trace 0000000000000000 ]---
[ 16.932990] alg: ahash: mv-hmac-md5 setkey failed on test vector 0; expected_error=0, actual_error=-80, flags=0x1
[ 16.943346] alg: self-tests for hmac(md5) using mv-hmac-md5 failed (rc=-80)
[ 16.943353] ------------[ cut here ]------------
[ 16.943357] WARNING: CPU: 0 PID: 391 at crypto/testmgr.c:5871 alg_test+0x5f0/0x614
[ 16.943370] alg: self-tests for hmac(md5) using mv-hmac-md5 failed (rc=-80)
[ 16.943374] Modules linked in: marvell_cesa libdes libaes
[ 16.943408] CPU: 0 UID: 0 PID: 391 Comm: cryptomgr_test Tainted: G W 6.15.0-rc5+ #5 NONE
[ 16.943418] Tainted: [W]=WARN
[ 16.943420] Hardware name: Marvell Armada 380/385 (Device Tree)
[ 16.943423] Call trace:
[ 16.943428] unwind_backtrace from show_stack+0x10/0x14
[ 16.943445] show_stack from dump_stack_lvl+0x50/0x64
[ 16.943455] dump_stack_lvl from __warn+0x7c/0xd4
[ 16.943465] __warn from warn_slowpath_fmt+0x110/0x16c
[ 16.943476] warn_slowpath_fmt from alg_test+0x5f0/0x614
[ 16.943487] alg_test from cryptomgr_test+0x18/0x38
[ 16.943495] cryptomgr_test from kthread+0xe8/0x204
[ 16.943504] kthread from ret_from_fork+0x14/0x28
[ 16.943512] Exception stack(0xf0ab9fb0 to 0xf0ab9ff8)
[ 16.943517] 9fa0: 00000000 00000000 00000000 00000000
[ 16.943522] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 16.943527] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 16.943530] ---[ end trace 0000000000000000 ]---
[ 16.943600] alg: ahash: mv-hmac-sha256 setkey failed on test vector 0; expected_error=0, actual_error=-80, flags=0x1
[ 16.954188] alg: self-tests for hmac(sha256) using mv-hmac-sha256 failed (rc=-80)
[ 16.954195] ------------[ cut here ]------------
[ 16.954200] WARNING: CPU: 0 PID: 394 at crypto/testmgr.c:5871 alg_test+0x5f0/0x614
[ 16.954211] alg: self-tests for hmac(sha256) using mv-hmac-sha256 failed (rc=-80)
[ 16.954215] Modules linked in: marvell_cesa libdes libaes
[ 16.954229] CPU: 0 UID: 0 PID: 394 Comm: cryptomgr_test Tainted: G W 6.15.0-rc5+ #5 NONE
[ 16.954236] Tainted: [W]=WARN
[ 16.954238] Hardware name: Marvell Armada 380/385 (Device Tree)
[ 16.954241] Call trace:
[ 16.954244] unwind_backtrace from show_stack+0x10/0x14
[ 16.954257] show_stack from dump_stack_lvl+0x50/0x64
[ 16.954266] dump_stack_lvl from __warn+0x7c/0xd4
[ 16.954275] __warn from warn_slowpath_fmt+0x110/0x16c
[ 16.954286] warn_slowpath_fmt from alg_test+0x5f0/0x614
[ 16.954296] alg_test from cryptomgr_test+0x18/0x38
[ 16.954304] cryptomgr_test from kthread+0xe8/0x204
[ 16.954312] kthread from ret_from_fork+0x14/0x28
[ 16.954320] Exception stack(0xf0ac5fb0 to 0xf0ac5ff8)
[ 16.954324] 5fa0: 00000000 00000000 00000000 00000000
[ 16.954329] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 16.954333] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 16.954336] ---[ end trace 0000000000000000 ]---