Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor

Klaus Kudielka
2025-05-14T05:12:55Z

On Tue, 2025-05-13 at 17:20 +0800, Herbert Xu wrote:
> On Sun, May 11, 2025 at 06:39:43PM +0200, Klaus Kudielka wrote:
> >
> > Here the log after modprobe, with the new printk patch:
>
> Thanks.  I'm starting to get the feeling that the partial hash
> is corrupted.
>
> Please apply this patch on top of the printk patch to confirm this.
>
> Cheers,

drivers/crypto/marvell/cesa/hash.c: In function ‘mv_cesa_ahash_complete’:
drivers/crypto/marvell/cesa/hash.c:403:25: error: implicit declaration of function ‘HASH_FBREQ_ON_STACK’; did you mean ‘SHASH_DESC_ON_STACK’? [-Wimplicit-function-declaration]
403 | HASH_FBREQ_ON_STACK(fbreq, ahashreq);
| ^~~~~~~~~~~~~~~~~~~
| SHASH_DESC_ON_STACK
drivers/crypto/marvell/cesa/hash.c:403:45: error: ‘fbreq’ undeclared (first use in this function)
403 | HASH_FBREQ_ON_STACK(fbreq, ahashreq);
| ^~~~~
drivers/crypto/marvell/cesa/hash.c:403:45: note: each undeclared identifier is reported only once for each function it appears in
drivers/crypto/marvell/cesa/hash.c:405:25: error: implicit declaration of function ‘crypto_ahash_import_core’; did you mean ‘crypto_ahash_import’? [-Wimplicit-function-declaration]
405 | crypto_ahash_import_core(fbreq, &state);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| crypto_ahash_import
CC [M] drivers/crypto/marvell/cesa/tdma.o
drivers/crypto/marvell/cesa/hash.c:407:25: error: implicit declaration of function ‘crypto_ahash_export_core’; did you mean ‘crypto_ahash_export’? [-Wimplicit-function-declaration]
407 | crypto_ahash_export_core(fbreq, &state);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| crypto_ahash_export
make[9]: *** [scripts/Makefile.build:203: drivers/crypto/marvell/cesa/hash.o] Error 1