From: Dave Hansen <dave.hansen@intel.com>
To: Bill Wendling <morbo@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Eric Biggers <ebiggers@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Justin Stitt <justinstitt@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org,
clang-built-linux <llvm@lists.linux.dev>
Subject: Re: [PATCH] x86/crc32: use builtins to improve code generation
Date: Thu, 27 Feb 2025 13:03:15 -0800 [thread overview]
Message-ID: <60941700-89e9-44c4-9e28-be482268d327@intel.com> (raw)
In-Reply-To: <CAGG=3QX-msHuRffAtNCBoqYo=15Z--5RXbPbJ=Tzkb+C9zNSaw@mail.gmail.com>
On 2/27/25 12:57, Bill Wendling wrote:
> I vastly prefer the first way if made "static __always_inline".
'static', for sure. But I'd leave the explicit inlining out unless the
compiler is actively being stupid.
next prev parent reply other threads:[~2025-02-27 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 6:12 [PATCH] x86/crc32: use builtins to improve code generation Bill Wendling
2025-02-27 6:28 ` Eric Biggers
2025-02-27 7:08 ` Bill Wendling
2025-02-28 2:08 ` Eric Biggers
2025-02-27 10:52 ` H. Peter Anvin
2025-02-27 12:17 ` Bill Wendling
2025-02-27 20:56 ` Bill Wendling
2025-02-27 16:26 ` Dave Hansen
2025-02-27 20:57 ` Bill Wendling
2025-02-27 21:03 ` Dave Hansen [this message]
2025-02-27 23:47 ` [PATCH v2] " Bill Wendling
2025-02-28 21:20 ` Eric Biggers
2025-02-28 21:29 ` Bill Wendling
2025-03-03 20:15 ` David Laight
2025-03-03 20:27 ` Bill Wendling
2025-03-03 22:42 ` David Laight
2025-03-03 23:57 ` H. Peter Anvin
2025-03-04 0:16 ` Bill Wendling
2025-03-04 0:43 ` H. Peter Anvin
2025-03-04 4:32 ` David Laight
2025-03-04 20:52 ` David Laight
2025-03-04 21:52 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60941700-89e9-44c4-9e28-be482268d327@intel.com \
--to=dave.hansen@intel.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@kernel.org \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox