From: Heiner Kallweit <hkallweit1@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH 4/5] hwrng: meson: use struct hw_random priv data
Date: Mon, 20 Feb 2023 00:51:25 +0100 [thread overview]
Message-ID: <61ec44bf-227b-3496-4452-d0c686e8a180@gmail.com> (raw)
In-Reply-To: <CAFBinCAL+UdDm6P-AhEkS-M7nR=HkFJQ-nijZU8qgp7ZCJ2aww@mail.gmail.com>
On 19.02.2023 19:26, Martin Blumenstingl wrote:
> Hi Heiner,
>
> On Sat, Feb 18, 2023 at 9:59 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>> + void __iomem *base = (__force void __iomem *)rng->priv;
> I find that "(void __force __iomem *)" is the more common order in
> other drivers. Which of these is correct is something I cannot tell
> though.
>
I just looked at this one:
#define IOMEM_ERR_PTR(err) (__force void __iomem *)ERR_PTR(err)
But right, both orders exist.
> Also I would like to hear some other opinions because to me the code
> was easier to read before.
Right, if possible I'd like to avoid it too.
However it's the prerequisite for getting rid of struct meson_rng_data.
And this simplification outweighs this small drawback IMO.
> Your way is shorter and may save a few bytes (including alignment etc.) though.
>
>
> Best regards,
> Martin
Heiner
next prev parent reply other threads:[~2023-02-19 23:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 20:54 [PATCH 0/5] hwrng: meson: simplify driver Heiner Kallweit
2023-02-18 20:55 ` [PATCH 1/5] hwrng: meson: remove unused member of struct meson_rng_data Heiner Kallweit
2023-02-19 17:26 ` Martin Blumenstingl
2023-02-18 20:56 ` [PATCH 2/5] hwrng: meson: use devm_clk_get_optional_enabled Heiner Kallweit
2023-02-19 17:27 ` Martin Blumenstingl
2023-02-18 20:57 ` [PATCH 3/5] hwrng: meson: remove not needed call to platform_set_drvdata Heiner Kallweit
2023-02-19 17:28 ` Martin Blumenstingl
2023-02-18 20:58 ` [PATCH 4/5] hwrng: meson: use struct hw_random priv data Heiner Kallweit
2023-02-19 18:26 ` Martin Blumenstingl
2023-02-19 23:51 ` Heiner Kallweit [this message]
2023-02-20 4:41 ` Herbert Xu
2023-02-20 7:18 ` Heiner Kallweit
2023-02-20 9:01 ` Herbert Xu
2023-02-18 20:59 ` [PATCH 5/5] hwrng: meson: remove struct meson_rng_data Heiner Kallweit
2023-03-10 11:26 ` [PATCH 0/5] hwrng: meson: simplify driver Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ec44bf-227b-3496-4452-d0c686e8a180@gmail.com \
--to=hkallweit1@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox