From: David Howells <dhowells@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
linux-crypto@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
James Morris <jmorris@namei.org>,
David Safford <safford@watson.ibm.com>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH v1.3 1/4] lib: hex2bin converts ascii hexadecimal string to binary
Date: Thu, 11 Nov 2010 19:48:47 +0000 [thread overview]
Message-ID: <6640.1289504927@redhat.com> (raw)
In-Reply-To: <1289404309-15955-2-git-send-email-zohar@linux.vnet.ibm.com>
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> +void hex2bin(unsigned char *mem, char *buf, int count)
I think this needs a little adjustment. I would recommend something like the
following declaration:
void hex2bin(u8 *buf, const char *data, size_t count)
since the output data is binary (so use u8*), you're only reading the source
data (so should use a const pointer) and you don't want to see a negative
count (so use size_t).
Also, I'd suggest calling the source arg 'data' and the output arg 'buf' or
maybe src/dst.
David
next prev parent reply other threads:[~2010-11-11 19:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 15:51 [PATCH v1.3 0/4] keys: trusted and encrypted keys Mimi Zohar
2010-11-10 15:51 ` [PATCH v1.3 1/4] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
2010-11-11 19:48 ` David Howells [this message]
2010-11-11 22:23 ` Mimi Zohar
2010-11-10 15:51 ` [PATCH v1.3 2/4] key: add tpm_send command Mimi Zohar
2010-11-11 19:48 ` David Howells
2010-11-11 22:25 ` Mimi Zohar
2010-11-12 14:11 ` David Howells
2010-11-12 14:48 ` David Safford
2010-11-12 21:24 ` Rajiv Andrade
2010-11-12 22:06 ` David Safford
2010-11-12 22:11 ` David Howells
2010-11-17 13:12 ` Rajiv Andrade
2010-11-10 15:51 ` [PATCH v1.3 3/4] keys: add new trusted key-type Mimi Zohar
2010-11-11 21:57 ` David Howells
2010-11-12 12:58 ` David Safford
2010-11-12 16:52 ` David Howells
2010-11-12 17:39 ` David Safford
2010-11-12 18:36 ` David Howells
2010-11-10 15:51 ` [PATCH v1.3 4/4] keys: add new key-type encrypted Mimi Zohar
2010-11-12 19:45 ` David Howells
2010-11-12 21:02 ` Mimi Zohar
2010-11-12 21:23 ` David Howells
2010-11-14 0:33 ` Mimi Zohar
2010-11-15 16:18 ` David Howells
2010-11-15 19:35 ` Mimi Zohar
2010-11-16 14:08 ` David Howells
2010-11-16 14:38 ` Mimi Zohar
2010-11-16 17:50 ` David Howells
2010-11-16 18:54 ` Mimi Zohar
2010-11-16 18:58 ` David Howells
2010-11-16 20:43 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6640.1289504927@redhat.com \
--to=dhowells@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).