From: Gary R Hook <ghook@amd.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Gary Hook <gary.hook@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()
Date: Mon, 19 Sep 2016 10:09:21 -0500 [thread overview]
Message-ID: <682aaa59-3367-b3e5-2748-b8a8fa7adcf7@amd.com> (raw)
In-Reply-To: <1474128082-14996-1-git-send-email-weiyj.lk@gmail.com>
On 09/17/2016 11:01 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in ccp_dmaengine_register().
>
> Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 94f77b0..32f645e 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -650,7 +650,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
> dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
> "%s-dmaengine-desc-cache",
> ccp->name);
> - if (!dma_cmd_cache_name)
> + if (!dma_desc_cache_name)
> return -ENOMEM;
> ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
> sizeof(struct ccp_dma_desc),
>
Acked-by: Gary R Hook <gary.hook@amd.com>
next prev parent reply other threads:[~2016-09-19 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 16:01 [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register() Wei Yongjun
2016-09-19 15:09 ` Gary R Hook [this message]
2016-09-22 10:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682aaa59-3367-b3e5-2748-b8a8fa7adcf7@amd.com \
--to=ghook@amd.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox