From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Varshini Rajendran <varshini.rajendran@microchip.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
Date: Mon, 21 Aug 2023 10:59:18 +0100 [thread overview]
Message-ID: <6c76b28e-e995-2082-6dfa-378002989bcd@linaro.org> (raw)
In-Reply-To: <a7b84b23-a1c1-23df-79db-d965ed261223@microchip.com>
On 8/21/23 09:59, Nicolas Ferre wrote:
> On 28/07/2023 at 12:24, Varshini Rajendran wrote:
>> Add DT bindings for atmel TDES.
this commit message is way too succinct and hides the complexity that's
needed in the driver
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>
> Following my answer to the email thread:
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Thanks, best regards,
> Nicolas
>
>> ---
>> .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> index 3d6ed24b1b00..6a441f79efea 100644
>> ---
>> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> +++
>> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> @@ -12,7 +12,11 @@ maintainers:
>> properties:
>> compatible:
>> - const: atmel,at91sam9g46-tdes
>> + oneOf:
>> + - const: atmel,at91sam9g46-tdes
>> + - items:
>> + - const: microchip,sam9x7-tdes
>> + - const: atmel,at91sam9g46-tdes
why do you backup to "atmel,at91sam9g46-tdes"? Simply relying on
"microchip,sam9x7-tdes" and its of_device_id data should be enough.
>> reg:
>> maxItems: 1
>
prev parent reply other threads:[~2023-08-21 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 10:24 [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES Varshini Rajendran
2023-07-28 11:17 ` Tudor Ambarus
2023-08-10 5:38 ` Varshini.Rajendran
2023-08-10 7:22 ` Tudor Ambarus
2023-08-19 14:34 ` Krzysztof Kozlowski
2023-08-21 8:41 ` Nicolas Ferre
2023-08-21 9:54 ` Tudor Ambarus
2023-08-21 12:10 ` Krzysztof Kozlowski
2023-08-21 13:00 ` Tudor Ambarus
2023-08-21 13:12 ` Krzysztof Kozlowski
2023-08-21 8:59 ` Nicolas Ferre
2023-08-21 9:59 ` Tudor Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c76b28e-e995-2082-6dfa-378002989bcd@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox