From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Vinod <vkoul@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v3 6/6] crypto: qcom: Add ACPI support
Date: Thu, 5 Jul 2018 08:26:49 -0600 [thread overview]
Message-ID: <6d8ee620-80d5-b529-1256-0624b1fbd98d@codeaurora.org> (raw)
In-Reply-To: <20180704041310.GV22377@vkoul-mobl>
On 7/3/2018 10:13 PM, Vinod wrote:
> On 03-07-18, 11:08, Jeffrey Hugo wrote:
>> On 7/3/2018 12:04 AM, Vinod Koul wrote:
>
>>> +#if IS_ENABLED(CONFIG_ACPI)
>>> +static const struct acpi_device_id qcom_rng_acpi_match[] = {
>>> + {
>>> + .id = "QCOM8160",
>>> + },
>>> + {}
>>> +};
>>> +MODULE_DEVICE_TABLE(acpi, msm_rng_acpi_match);
>>
>> qcom_rng_acpi_match?
>> Looks like a copy/paste issue. This causes a build failure for me.
>> I'm trying to see if it works otherwise...
>
> Ah sorry about that, I though I had fixed it, looks like I missed to
> fold the fix.
>
> Did it work for you?
>
It seems to work. Driver compiles, and loads. Still working on the
verification.
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2018-07-05 14:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 6:04 [PATCH v3 0/6] crypto: Add Qcom PRNG support Vinod Koul
2018-07-03 6:04 ` [PATCH v3 1/6] hwrng: remove msm hw_random driver Vinod Koul
2018-07-03 6:04 ` [PATCH v3 2/6] dt-bindings: crypto: Move prng binding to crypto Vinod Koul
2018-07-03 6:04 ` [PATCH v3 3/6] crypto: Add Qcom prng driver Vinod Koul
2018-07-03 13:28 ` Stephan Mueller
2018-07-04 4:10 ` Vinod
2018-07-04 6:10 ` Vinod
2018-07-04 6:16 ` Stephan Mueller
2018-07-04 13:42 ` Timur Tabi
2018-07-04 16:02 ` Stephan Mueller
2018-07-05 6:01 ` Vinod
2018-07-03 6:04 ` [PATCH v3 4/6] dt-bindings: crypto: Add new compatible qcom,prng-ee Vinod Koul
2018-07-03 6:04 ` [PATCH v3 5/6] crypto: qcom: Add support for prng-ee Vinod Koul
2018-07-03 6:04 ` [PATCH v3 6/6] crypto: qcom: Add ACPI support Vinod Koul
2018-07-03 14:10 ` Timur Tabi
2018-07-04 4:11 ` Vinod
2018-07-03 17:08 ` Jeffrey Hugo
2018-07-04 4:13 ` Vinod
2018-07-05 14:26 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8ee620-80d5-b529-1256-0624b1fbd98d@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox