From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>, linux-crypto@vger.kernel.org
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
x86@kernel.org
Subject: Re: [PATCH] lib/crypto: x86/blake2s: Drop redundant checks for AVX and AVX512F
Date: Fri, 13 Nov 2026 09:30:24 +0100 [thread overview]
Message-ID: <6f5f6852-5cc5-401b-8a85-d5e863f9da3c@app.fastmail.com> (raw)
In-Reply-To: <20261111201436.39855-1-ebiggers@kernel.org>
On Wed, 11 Nov 2026, at 21:14, Eric Biggers wrote:
> X86_FEATURE_AVX2 implies X86_FEATURE_AVX. Similarly,
> X86_FEATURE_AVX512VL implies X86_FEATURE_AVX512F (and X86_FEATURE_AVX).
>
> Simplify blake2s_mod_init_arch() accordingly. Also nest these checks
> under the block that sets the static key for blake2s_use_ssse3,
> mirroring the code that uses these static keys.
>
> (Note: as usual, arch/x86/kernel/cpu/cpuid-deps.c is non-enforcing: if a
> dependency isn't met, it warns and doesn't prevent booting. However,
> that case doesn't occur in real CPUs and is unsupported.)
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> lib/crypto/x86/blake2s.h | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
next prev parent reply other threads:[~2026-11-13 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 20:14 [PATCH] lib/crypto: x86/blake2s: Drop redundant checks for AVX and AVX512F Eric Biggers
2026-11-13 8:30 ` Ard Biesheuvel [this message]
2026-11-14 4:23 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f5f6852-5cc5-401b-8a85-d5e863f9da3c@app.fastmail.com \
--to=ardb@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox