From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBE7C04A68 for ; Thu, 28 Jul 2022 08:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbiG1IYk (ORCPT ); Thu, 28 Jul 2022 04:24:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234504AbiG1IYj (ORCPT ); Thu, 28 Jul 2022 04:24:39 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD5B6248D for ; Thu, 28 Jul 2022 01:24:38 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ltk9j4PNWzWfmR; Thu, 28 Jul 2022 16:20:41 +0800 (CST) Received: from [10.67.110.173] (10.67.110.173) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 16:24:36 +0800 Message-ID: <761e849c-3b9d-418e-eb68-664f09b3c661@huawei.com> Date: Thu, 28 Jul 2022 16:24:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: Inquiry about the removal of flag O_NONBLOCK on /dev/random Content-Language: en-US From: "Guozihua (Scott)" To: "Jason A. Donenfeld" CC: Eric Biggers , , , , zhongguohua References: <13e1fa9d-4df8-1a99-ca22-d9d655f2d023@huawei.com> <29c4a3ec-f23f-f17f-da49-7d79ad88e284@huawei.com> <4a794339-7aaa-8951-8d24-9bc8a79fa9f3@huawei.com> In-Reply-To: <4a794339-7aaa-8951-8d24-9bc8a79fa9f3@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.173] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500024.china.huawei.com (7.185.36.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2022/7/26 19:33, Guozihua (Scott) wrote: > On 2022/7/26 19:08, Jason A. Donenfeld wrote: >> Hi, >> >> On Tue, Jul 26, 2022 at 03:43:31PM +0800, Guozihua (Scott) wrote: >>> Thanks for all the comments on this inquiry. Does the community has any >>> channel to publishes changes like these? And will the man pages get >>> updated? If so, are there any time frame? >> >> I was under the impression you were ultimately okay with the status quo. >> Have I misunderstood you? >> >> Thanks, >> Jason >> . > > Hi Jason. > > To clarify, I does not have any issue with this change. I asked here > only because I would like some background knowledge on this flag, to > ensure I am on the same page as the community regarding this flag and > the change. And it seems that I understands it correctly. > > However I do think it's a good idea to update the document soon to avoid > any misunderstanding in the future. > Our colleague suggests that we should inform users clearly about the change on the flag by returning -EINVAL when /dev/random gets this flag during boot process. Otherwise programs might silently block for a long time, causing other issues. Do you think this is a good way to prevent similar issues on this flag? -- Best GUO Zihua