linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [REPORT] Possible unnecessary usages of GFP_ATOMIC in crypto/ablkcipher.c
Date: Mon, 23 Jul 2018 10:39:40 +0800	[thread overview]
Message-ID: <78a7d726-f2fa-3afb-3451-bbd51a41a48a@gmail.com> (raw)

My tool DCNS reports three unnecessary usages of GFP_ATOMIC in 
crypto/ablkcipher.c:
crypto/ablkcipher.c, 162: kmalloc(GFP_ATOMIC) in ablkcipher_next_slow
crypto/ablkcipher.c, 199: kmalloc(GFP_ATOMIC) in ablkcipher_copy_iv
crypto/ablkcipher.c, 315: kmalloc(GFP_ATOMIC) in setkey_unaligned

I meant to manually check the code, but I find that there are many 
functions calling ablkcipher_next_slow(),
ablkcipher_copy_iv() and setkey_unaligned(), so I am not sure whether 
the above three reports are true.

Could someone help me to validate these reports?
Thanks a lot in advance :)


Best wishes,
Jia-Ju Bai

             reply	other threads:[~2018-07-23  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23  2:39 Jia-Ju Bai [this message]
2018-07-23  6:21 ` [REPORT] Possible unnecessary usages of GFP_ATOMIC in crypto/ablkcipher.c Herbert Xu
2018-07-23  7:19   ` Jia-Ju Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78a7d726-f2fa-3afb-3451-bbd51a41a48a@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).