From: Tom Lendacky <thomas.lendacky@amd.com>
To: Thomas Courrege <thomas.courrege@vates.tech>,
pbonzini@redhat.com, seanjc@google.com, corbet@lwn.net,
ashish.kalra@amd.com, john.allen@amd.com,
herbert@gondor.apana.org.au, nikunj@amd.com
Cc: x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] KVM: SEV: Add KVM_SEV_SNP_HV_REPORT_REQ command
Date: Fri, 5 Dec 2025 08:28:41 -0600 [thread overview]
Message-ID: <7b3c264c-03bb-4dc5-b5c6-24fb0bd179cf@amd.com> (raw)
In-Reply-To: <85baa45b-0fb9-43fb-9f87-9b0036e08f56@vates.tech>
On 12/4/25 07:21, Thomas Courrege wrote:
> On 12/2/25 8:29 PM, Tom Lendacky wrote:
>
>>> +
>>> +e_free_rsp:
>>> + /* contains sensitive data */
>>> + memzero_explicit(report_rsp, PAGE_SIZE);
>> Does it? What is sensitive that needs to be cleared?
>
> Combine with others reports, it could allow to do an inventory of the guests,
> which ones share the same author, measurement, policy...
> It is not needed, but generating a report is not a common operation so
> performance is not an issue here. What do you think is the best to do ?
Can't userspace do that just by generating/requesting reports? If there
are no keys, IVs, secrets, etc. in the memory, I don't see what the
memzero_explicit() is accomplishing. Maybe I'm missing something here and
others may have different advice.
Thanks,
Tom
>
> Regards,
> Thomas
next prev parent reply other threads:[~2025-12-05 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 15:19 [PATCH v2] KVM: SEV: Add KVM_SEV_SNP_HV_REPORT_REQ command Thomas Courrege
2025-12-02 19:28 ` Tom Lendacky
2025-12-04 13:21 ` Thomas Courrege
2025-12-05 14:28 ` Tom Lendacky [this message]
2025-12-12 10:19 ` Thomas Courrege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3c264c-03bb-4dc5-b5c6-24fb0bd179cf@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ashish.kalra@amd.com \
--cc=corbet@lwn.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.courrege@vates.tech \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox