From: Liwei Song <liwei.song@windriver.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Gary Hook <gary.hook@amd.com>, David <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: ccp - zero the cmd data after use it
Date: Tue, 4 Aug 2020 12:43:21 +0800 [thread overview]
Message-ID: <7f5e38f8-c7a4-65c7-647b-749f66ccc48b@windriver.com> (raw)
In-Reply-To: <20200804042215.GA10939@gondor.apana.org.au>
On 8/4/20 12:22, Herbert Xu wrote:
> On Tue, Aug 04, 2020 at 12:20:21PM +0800, Liwei Song wrote:
>>
>> Yes, the other process should do this zero work, but the case I met is
>> this address will appear in the slab_alloc_node() as freelist pointer of slub,
>> and before slub do zero wrok, even kzalloc() doesn't work with this address.
>
> That would be memory corruption which has nothing to do with your
> patch. If it is occurring then you should fix the place that is
> corrupting the memory and not work around it like this.
OK, understand, thanks for your suggestion.
Liwei.
>
> Cheers,
>
prev parent reply other threads:[~2020-08-04 4:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 7:58 [PATCH] crypto: ccp - zero the cmd data after use it Liwei Song
2020-08-03 12:52 ` Herbert Xu
2020-08-04 3:51 ` Liwei Song
2020-08-04 4:04 ` Herbert Xu
2020-08-04 4:20 ` Liwei Song
2020-08-04 4:22 ` Herbert Xu
2020-08-04 4:43 ` Liwei Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f5e38f8-c7a4-65c7-647b-749f66ccc48b@windriver.com \
--to=liwei.song@windriver.com \
--cc=davem@davemloft.net \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).