From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-kernel@vger.kernel.org, cgel.zte@gmail.com
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] crypto: sun8i-ce:using the pm_runtime_resume_and_get to simplify the code
Date: Sun, 14 Aug 2022 12:13:52 +0200 [thread overview]
Message-ID: <8140378.NyiUUSuA9g@jernej-laptop> (raw)
In-Reply-To: <20220802074820.1648786-1-ye.xingchen@zte.com.cn>
Dne torek, 02. avgust 2022 ob 09:48:20 CEST je cgel.zte@gmail.com napisal(a):
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
> and pm_runtime_put_noidle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c
> b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c index
> 19cd2e52f89d..ef9cfc61af32 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c
> @@ -54,9 +54,8 @@ static int sun8i_ce_trng_read(struct hwrng *rng, void
> *data, size_t max, bool wa goto err_dst;
> }
>
> - err = pm_runtime_get_sync(ce->dev);
> + err = pm_runtime_resume_and_get(ce->dev);
> if (err < 0) {
> - pm_runtime_put_noidle(ce->dev);
> goto err_pm;
> }
You should also remove braces, since there is only one line left.
With that fixed:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2022-08-14 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:48 [PATCH linux-next] crypto: sun8i-ce:using the pm_runtime_resume_and_get to simplify the code cgel.zte
2022-08-14 10:13 ` Jernej Škrabec [this message]
2022-08-19 11:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8140378.NyiUUSuA9g@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=cgel.zte@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox