From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Paul Louvel <paul.louvel@bootlin.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/29] crypto: talitos/hash - Use macro for algorithm definitions
Date: Mon, 1 Jun 2026 14:02:04 +0200 [thread overview]
Message-ID: <8246e50a-cfdb-472e-a2e0-c68b47751af5@kernel.org> (raw)
In-Reply-To: <20260528-7-1-rc1_talitos_cleanup-v1-15-cb1ad6cdea49@bootlin.com>
Le 28/05/2026 à 11:08, Paul Louvel a écrit :
> Replace the repetitive struct initializer entries in hash_driver_algs[]
> with preprocessor macros (TALITOS_HASH_ALG, TALITOS_HMAC_HASH_ALG).
>
> Remove the function pointer assignments (init_tfm, exit_tfm, init, update,
> final, finup, digest, export, import).
>
> The HMAC setkey assignment, previously done by comparing the algorithm
> name at runtime, is now handled by passing ahash_setkey directly through
> the TALITOS_HMAC_HASH_ALG macro variant.
>
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> drivers/crypto/talitos/talitos-hash.c | 392 +++++++++-------------------------
> 1 file changed, 104 insertions(+), 288 deletions(-)
>
> diff --git a/drivers/crypto/talitos/talitos-hash.c b/drivers/crypto/talitos/talitos-hash.c
> index f7f6f01cfddf..9e6d849c3123 100644
> --- a/drivers/crypto/talitos/talitos-hash.c
> +++ b/drivers/crypto/talitos/talitos-hash.c
> @@ -551,283 +551,111 @@ static void talitos_cra_exit_ahash(struct crypto_ahash *tfm)
> talitos_cra_exit(crypto_ahash_tfm(tfm));
> }
>
> -static struct talitos_alg_template hash_driver_algs[] = {
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = MD5_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "md5",
> - .cra_driver_name = "md5-talitos",
> - .cra_blocksize = MD5_HMAC_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_MD5,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA1_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "sha1",
> - .cra_driver_name = "sha1-talitos",
> - .cra_blocksize = SHA1_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA1,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA224_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "sha224",
> - .cra_driver_name = "sha224-talitos",
> - .cra_blocksize = SHA224_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA224,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA256_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "sha256",
> - .cra_driver_name = "sha256-talitos",
> - .cra_blocksize = SHA256_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA256,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA384_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "sha384",
> - .cra_driver_name = "sha384-talitos",
> - .cra_blocksize = SHA384_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUB |
> - DESC_HDR_MODE0_MDEUB_SHA384,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA512_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "sha512",
> - .cra_driver_name = "sha512-talitos",
> - .cra_blocksize = SHA512_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUB |
> - DESC_HDR_MODE0_MDEUB_SHA512,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = MD5_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(md5)",
> - .cra_driver_name = "hmac-md5-talitos",
> - .cra_blocksize = MD5_HMAC_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_MD5,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA1_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(sha1)",
> - .cra_driver_name = "hmac-sha1-talitos",
> - .cra_blocksize = SHA1_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA1,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA224_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(sha224)",
> - .cra_driver_name = "hmac-sha224-talitos",
> - .cra_blocksize = SHA224_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA224,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA256_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(sha256)",
> - .cra_driver_name = "hmac-sha256-talitos",
> - .cra_blocksize = SHA256_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUA |
> - DESC_HDR_MODE0_MDEU_SHA256,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA384_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(sha384)",
> - .cra_driver_name = "hmac-sha384-talitos",
> - .cra_blocksize = SHA384_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUB |
> - DESC_HDR_MODE0_MDEUB_SHA384,
> - },
> - { .type = CRYPTO_ALG_TYPE_AHASH,
> - .alg.hash = {
> - .halg.digestsize = SHA512_DIGEST_SIZE,
> - .halg.statesize = sizeof(struct talitos_export_state),
> - .halg.base = {
> - .cra_name = "hmac(sha512)",
> - .cra_driver_name = "hmac-sha512-talitos",
> - .cra_blocksize = SHA512_BLOCK_SIZE,
> - .cra_reqsize = sizeof(struct talitos_ahash_req_ctx),
> - .cra_flags = CRYPTO_ALG_ASYNC |
> - CRYPTO_ALG_ALLOCATES_MEMORY |
> - CRYPTO_ALG_KERN_DRIVER_ONLY |
> - CRYPTO_AHASH_ALG_BLOCK_ONLY |
> - CRYPTO_AHASH_ALG_FINAL_NONZERO,
> - .cra_priority = TALITOS_CRA_PRIORITY,
> - .cra_ctxsize = sizeof(struct talitos_ctx),
> - .cra_module = THIS_MODULE,
> - }
> - },
> - .desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> - DESC_HDR_SEL0_MDEUB |
> - DESC_HDR_MODE0_MDEUB_SHA512,
> +#define TALITOS_HASH_ALG_COMMON(name, digest_size, block_size, template, \
> + set_key) \
> + { \
> + .type = CRYPTO_ALG_TYPE_AHASH, \
> + .alg.hash = { \
> + .init_tfm = talitos_cra_init_ahash, \
> + .exit_tfm = talitos_cra_exit_ahash, \
> + .init = ahash_init, \
> + .update = ahash_update, \
> + .final = ahash_final, \
> + .finup = ahash_finup, \
> + .digest = ahash_digest, \
> + .setkey = set_key, \
> + .import = ahash_import, \
> + .export = ahash_export, \
> + .halg.digestsize = digest_size, \
> + .halg.statesize = sizeof(struct talitos_export_state), \
> + .halg.base = { \
> + .cra_name = name, \
> + .cra_driver_name = name"-talitos", \
> + .cra_blocksize = block_size, \
> + .cra_reqsize = sizeof(struct talitos_ahash_req_ctx), \
> + .cra_flags = CRYPTO_ALG_ASYNC | \
> + CRYPTO_ALG_ALLOCATES_MEMORY | \
> + CRYPTO_ALG_KERN_DRIVER_ONLY | \
> + CRYPTO_AHASH_ALG_BLOCK_ONLY | \
> + CRYPTO_AHASH_ALG_FINAL_NONZERO, \
> + .cra_priority = TALITOS_CRA_PRIORITY, \
> + .cra_ctxsize = sizeof(struct talitos_ctx), \
> + .cra_module = THIS_MODULE, \
> + }, \
> + }, \
> + .desc_hdr_template = template, \
> }
> +
> +#define TALITOS_HASH_ALG(name, digest_size, block_size, desc_hdr_template) \
> + TALITOS_HASH_ALG_COMMON(name, digest_size, block_size, \
> + desc_hdr_template, NULL)
> +
> +#define TALITOS_HMAC_HASH_ALG(name, digest_size, block_size, \
> + desc_hdr_template) \
> + TALITOS_HASH_ALG_COMMON("hmac(" name ")", digest_size, block_size, \
> + desc_hdr_template, ahash_setkey)
> +
> +static struct talitos_alg_template hash_driver_algs[] = {
> + TALITOS_HASH_ALG("md5", MD5_DIGEST_SIZE, MD5_HMAC_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA | DESC_HDR_MODE0_MDEU_MD5),
> +
> + TALITOS_HASH_ALG("sha1", SHA1_DIGEST_SIZE, SHA1_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA1),
> +
> + TALITOS_HASH_ALG("sha224", SHA224_DIGEST_SIZE, SHA224_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA224),
> +
> + TALITOS_HASH_ALG("sha256", SHA256_DIGEST_SIZE, SHA256_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA256),
> +
> + TALITOS_HASH_ALG("sha384", SHA384_DIGEST_SIZE, SHA384_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUB |
> + DESC_HDR_MODE0_MDEUB_SHA384),
> +
> + TALITOS_HASH_ALG("sha512", SHA512_DIGEST_SIZE, SHA512_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUB |
> + DESC_HDR_MODE0_MDEUB_SHA512),
> +
> + /* HMAC */
> +
> + TALITOS_HMAC_HASH_ALG("md5", MD5_DIGEST_SIZE, MD5_HMAC_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_MD5),
> +
> + TALITOS_HMAC_HASH_ALG("sha1", SHA1_DIGEST_SIZE, SHA1_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA1),
> +
> + TALITOS_HMAC_HASH_ALG("sha224", SHA224_DIGEST_SIZE, SHA224_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA224),
> +
> + TALITOS_HMAC_HASH_ALG("sha256", SHA256_DIGEST_SIZE, SHA256_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUA |
> + DESC_HDR_MODE0_MDEU_SHA256),
> +
> + TALITOS_HMAC_HASH_ALG("sha384", SHA384_DIGEST_SIZE, SHA384_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUB |
> + DESC_HDR_MODE0_MDEUB_SHA384),
> +
> + TALITOS_HMAC_HASH_ALG("sha512", SHA512_DIGEST_SIZE, SHA512_BLOCK_SIZE,
> + DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
> + DESC_HDR_SEL0_MDEUB |
> + DESC_HDR_MODE0_MDEUB_SHA512),
> };
>
> int talitos_register_hash(struct device *dev)
> @@ -846,18 +674,6 @@ int talitos_register_hash(struct device *dev)
> ahash_alg = &hash_driver_algs[i].alg.hash;
> alg = &ahash_alg->halg.base;
>
> - ahash_alg->init_tfm = talitos_cra_init_ahash;
> - ahash_alg->exit_tfm = talitos_cra_exit_ahash;
> - ahash_alg->init = ahash_init;
> - ahash_alg->update = ahash_update;
> - ahash_alg->final = ahash_final;
> - ahash_alg->finup = ahash_finup;
> - ahash_alg->digest = ahash_digest;
> - if (!strncmp(alg->cra_name, "hmac", 4))
> - ahash_alg->setkey = ahash_setkey;
> - ahash_alg->import = ahash_import;
> - ahash_alg->export = ahash_export;
> -
> if (!(priv->features & TALITOS_FTR_HMAC_OK) &&
> !strncmp(alg->cra_name, "hmac", 4)) {
> /* not supported */
>
next prev parent reply other threads:[~2026-06-01 12:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:08 [PATCH 00/29] crypto: talitos - Driver cleanup Paul Louvel
2026-05-28 9:08 ` [PATCH 01/29] crypto: talitos/hash - Use CRYPTO_AHASH_BLOCK_ONLY API Paul Louvel
2026-05-29 11:25 ` Christophe Leroy (CS GROUP)
2026-06-01 5:40 ` Christophe Leroy (CS GROUP)
2026-06-01 8:06 ` Paul Louvel
2026-05-28 9:08 ` [PATCH 02/29] crypto: talitos - Move driver into dedicated directory Paul Louvel
2026-05-29 11:25 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 03/29] crypto: talitos - Add missing includes to driver header file Paul Louvel
2026-05-29 11:26 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 04/29] crypto: talitos/hwrng - Move into separate file Paul Louvel
2026-05-29 11:26 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 05/29] crypto: talitos - Prepare crypto implementation file splitting Paul Louvel
2026-05-29 13:21 ` Christophe Leroy (CS GROUP)
2026-05-29 16:24 ` David Laight
2026-06-01 8:49 ` Paul Louvel
2026-06-01 10:16 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 06/29] crypto: talitos - Introduce registration helper Paul Louvel
2026-06-01 5:45 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 07/29] crypto: talitos/hash - Move into separate file Paul Louvel
2026-06-01 11:47 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 08/29] crypto: talitos/skcipher " Paul Louvel
2026-06-01 11:47 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 09/29] crypto: talitos/aead " Paul Louvel
2026-06-01 11:48 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 10/29] crypto: talitos - Remove alg settings in talitos_register_common() Paul Louvel
2026-06-01 11:53 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 11/29] crypto: talitos - Remove unused priority field in struct talitos_alg_template Paul Louvel
2026-06-01 11:54 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 12/29] crypto: talitos/hash - Convert to init_tfm/exit_tfm type-specific API Paul Louvel
2026-06-01 11:57 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 13/29] crypto: talitos/skcipher - Convert to init/exit " Paul Louvel
2026-06-01 11:58 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 14/29] crypto: talitos/aead " Paul Louvel
2026-06-01 11:59 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 15/29] crypto: talitos/hash - Use macro for algorithm definitions Paul Louvel
2026-06-01 12:02 ` Christophe Leroy (CS GROUP) [this message]
2026-05-28 9:08 ` [PATCH 16/29] crypto: talitos/skcipher " Paul Louvel
2026-06-01 12:02 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 17/29] crypto: talitos/aead " Paul Louvel
2026-06-01 12:12 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 18/29] crypto: talitos - Split SEC1/SEC2 code into separate function variants Paul Louvel
2026-06-01 5:51 ` Christophe Leroy (CS GROUP)
2026-06-01 12:32 ` Christophe Leroy (CS GROUP)
2026-05-28 9:08 ` [PATCH 19/29] crypto: talitos - Introduce struct talitos_ops Paul Louvel
2026-05-28 9:08 ` [PATCH 20/29] crypto: talitos - Replace SEC1/SEC2 conditionals with ops dispatch Paul Louvel
2026-05-28 9:08 ` [PATCH 21/29] crypto: talitos - Export common channel and error handling routines Paul Louvel
2026-05-28 9:08 ` [PATCH 22/29] crypto: talitos - Move SEC1 ops into talitos-sec1.c Paul Louvel
2026-05-28 9:08 ` [PATCH 23/29] crypto: talitos - Move SEC2 ops into talitos-sec2.c Paul Louvel
2026-05-28 9:08 ` [PATCH 24/29] crypto: talitos - Introduce per-SEC-version pointer helper ops Paul Louvel
2026-05-28 9:08 ` [PATCH 25/29] crypto: talitos - Dispatch pointer helpers through ptr_ops Paul Louvel
2026-05-28 9:08 ` [PATCH 26/29] crypto: talitos - Remove now-unused global pointer helpers Paul Louvel
2026-05-28 9:08 ` [PATCH 27/29] crypto: talitos - Introduce per-SEC-version descriptor structures and ops Paul Louvel
2026-05-28 9:08 ` [PATCH 28/29] crypto: talitos - Clean up includes in core driver file Paul Louvel
2026-05-28 9:08 ` [PATCH 29/29] crypto: talitos - Remove TALITOS_DESC_SIZE macro Paul Louvel
2026-06-01 6:15 ` [PATCH 00/29] crypto: talitos - Driver cleanup Christophe Leroy (CS GROUP)
2026-06-01 9:17 ` Paul Louvel
2026-06-01 10:27 ` Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8246e50a-cfdb-472e-a2e0-c68b47751af5@kernel.org \
--to=chleroy@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=herve.codina@bootlin.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.louvel@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox