From: Florian Fainelli <f.fainelli@gmail.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-crypto@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[]
Date: Wed, 1 Jul 2020 14:52:36 -0700 [thread overview]
Message-ID: <83b5c8b5-484a-d688-3c22-b15e388575cd@gmail.com> (raw)
In-Reply-To: <20200701200950.30314-2-rikard.falkeborn@gmail.com>
On 7/1/2020 1:09 PM, Rikard Falkeborn wrote:
> bcm2835_rng_devtype[] is not modified and can be made const to allow the
> compiler to put it in read-only memory.
>
> Before:
> text data bss dec hex filename
> 2392 176 0 2568 a08 drivers/char/hw_random/bcm2835-rng.o
>
> After:
> text data bss dec hex filename
> 2464 104 0 2568 a08 drivers/char/hw_random/bcm2835-rng.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-01 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 20:09 [PATCH 0/5] drivers/char: Constify static variables Rikard Falkeborn
2020-07-01 20:09 ` [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[] Rikard Falkeborn
2020-07-01 21:52 ` Florian Fainelli [this message]
2020-07-01 20:09 ` [PATCH 2/5] hwrng: nomadik - Constify nmk_rng_ids[] Rikard Falkeborn
2020-07-02 7:51 ` Arnd Bergmann
2020-07-01 20:09 ` [PATCH 3/5] hwrng: virtio - Constify id_table[] Rikard Falkeborn
2020-07-02 8:58 ` [PATCH 0/5] drivers/char: Constify static variables Arnd Bergmann
2020-07-09 12:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b5c8b5-484a-d688-3c22-b15e388575cd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox