Re: [PATCH] crypto: vmac - remove unused VMAC algorithm

[Milan Broz <gmazyland@gmail.com>]

On 12/26/24 8:43 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Remove the vmac64 template, as it has no known users.  It also continues
> to have longstanding bugs such as alignment violations (see
> https://lore.kernel.org/r/20241226134847.6690-1-evepolonium@gmail.com/).

...

> No in-tree user has appeared since then, other than potentially the
> usual components that allow specifying arbitrary hash algorithms by
> name, namely AF_ALG and dm-integrity.  However there are no indications
> that VMAC is being used with these components.  Debian Code Search and
> web searches for "vmac64" (the actual algorithm name) do not return any
> results other than the kernel itself, suggesting that it does not appear
> in any other code or documentation.  Explicitly grepping the source code
> of the usual suspects (libell, iwd, cryptsetup) finds no matches either.

AFAIK it was never used for dm-integrity / cryptsetup and I am not even able
to make it work for test now (isn't the vmac64 alg module init even broken?).

Just remove it...

Thanks,
Milan