Re: [PATCH] crypto: atmel-ecc - Remove duplicated error reporting in .remove()

[<Tudor.Ambarus@microchip.com>]

On 6/8/22 10:04, Uwe Kleine-König wrote:
> Hello
> 

Hi,

> On Wed, Jun 08, 2022 at 04:33:48AM +0000, Tudor.Ambarus@microchip.com wrote:
>> On 5/20/22 20:21, Uwe Kleine-König wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Returning an error value in an i2c remove callback results in an error
>>> message being emitted by the i2c core, but otherwise it doesn't make a
>>> difference. The device goes away anyhow and the devm cleanups are
>>> called.
>>>
>>> As atmel_ecc_remove() already emits an error message on failure and the
>>> additional error message by the i2c core doesn't add any useful
>>> information, change the return value to zero to suppress this message.
>>>
>>> Also make the error message a bit more drastical because when the device
>>> is still busy on remove, it's likely that it will access freed memory
>>> soon.
>>>
>>> This patch is a preparation for making i2c remove callbacks return void.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> In the past patches were picked up by Herbert. I assume your R-b tag was

he still does.

> the missing bit to make him pick up this patch? To make a bit more sure

probably not.

> that will happen, I added him and davem to Cc.

Herbert usually queues patches in a two week time frame. Let's wait for him.

Cheers,
ta