From: Kalle Valo <kvalo@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
Matt Mackall <mpm@selenic.com>,
ath9k-devel@qca.qualcomm.com, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] random: pull add_hwgenerator_randomness() declaration into random.h
Date: Mon, 14 Feb 2022 13:43:46 +0200 [thread overview]
Message-ID: <8735klbrm5.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20220213152522.816777-1-Jason@zx2c4.com> (Jason A. Donenfeld's message of "Sun, 13 Feb 2022 16:25:22 +0100")
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> add_hwgenerator_randomness() is a function implemented and documented
> inside of random.c. It is the way that hardware RNGs push data into it.
> Therefore, it should be declared in random.h. Otherwise sparse complains
> with:
>
> random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static?
>
> The alternative would be to include hw_random.h into random.c, but that
> wouldn't really be good for anything except slowing down compile time.
>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Cc: Matt Mackall <mpm@selenic.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: linux-crypto@vger.kernel.org
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: ath9k-devel@qca.qualcomm.com
> Cc: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> drivers/char/hw_random/core.c | 1 +
> drivers/net/wireless/ath/ath9k/rng.c | 1 +
For ath9k:
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-02-14 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 15:25 [PATCH] random: pull add_hwgenerator_randomness() declaration into random.h Jason A. Donenfeld
2022-02-13 15:33 ` Jason A. Donenfeld
2022-02-13 19:42 ` Dominik Brodowski
2022-02-14 11:43 ` Kalle Valo [this message]
2022-02-16 11:43 ` Jason A. Donenfeld
2022-02-18 4:27 ` Herbert Xu
2022-02-21 5:52 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735klbrm5.fsf@tynnyri.adurom.net \
--to=kvalo@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mpm@selenic.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox