Re: [PATCH v4 6/8] crypto: qat - simplify adf_enable_aer()

Uwe Kleine-König
2021-09-28T13:57:16Z

[-- Attachment #1: Type: text/plain, Size: 2273 bytes --]

Hello,

On Tue, Sep 28, 2021 at 01:26:37PM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 28, 2021 at 12:11:38PM +0100, Giovanni Cabiddu wrote:
> > On Mon, Sep 27, 2021 at 10:43:24PM +0200, Uwe Kleine-König wrote:
> > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > A struct pci_driver is supposed to be constant and assigning .err_handler
> > > once per bound device isn't really sensible. Also as the function returns
> > > zero unconditionally let it return no value instead and simplify the
> > > callers accordingly.
> > >
> > > As a side effect this removes one user of struct pci_dev::driver. This
> > > member is planned to be removed.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> >
> > this patch does not build.
> >
> > drivers/crypto/qat/qat_c3xxx/adf_drv.c:36:24: error: ‘adf_err_handler’ undeclared here (not in a function)
> > 36 | .err_handler = adf_err_handler,
> > | ^~~~~~~~~~~~~~~
> > drivers/crypto/qat/qat_4xxx/adf_drv.c:303:24: error: ‘adf_err_handler’ undeclared here (not in a function)
> > 303 | .err_handler = adf_err_handler,
> > | ^~~~~~~~~~~~~~~
> > drivers/crypto/qat/qat_c62x/adf_drv.c:36:24: error: ‘adf_err_handler’ undeclared here (not in a function)
> > 36 | .err_handler = adf_err_handler,
> > | ^~~~~~~~~~~~~~~
> > drivers/crypto/qat/qat_dh895xcc/adf_drv.c:36:24: error: ‘adf_err_handler’ undeclared here (not in a function)
> > 36 | .err_handler = adf_err_handler,
> > | ^~~~~~~~~~~~~~~
> > make[2]: *** [scripts/Makefile.build:277: drivers/crypto/qat/qat_c3xxx/adf_drv.o] Error 1
>
> Hmm, I thought that was one of the things I actually tested after
> rebasing. Will recheck.

I fixed it now, comparing with your patch the only thing I did
differently is ordering in the header file.

I pushed the fixed series to

https://git.pengutronix.de/git/ukl/linux pci-dedup

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]