From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v6 13/18] wireless/lib80211: Convert from ahash to shash Date: Wed, 25 Jul 2018 11:05:42 +0300 Message-ID: <87tvong2p5.fsf@purkki.adurom.net> References: <20180724164936.37477-1-keescook@chromium.org> <20180724164936.37477-14-keescook@chromium.org> <1532503493.3223.0.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Giovanni Cabiddu , Mike Snitzer , Eric Biggers , linux-wireless@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, David Howells , dm-devel@redhat.com, Jia-Ju Bai , Paul Mackerras , Pavel Machek , "H. Peter Anvin" , linux-afs@lists.infradead.org, Alasdair Kergon , Rabin Vincent , devel@driverdev.osuosl.org, Herbert Xu , x86@kernel.org, "Gustavo A. R. Silva" , qat-linux@intel.com, Ingo Molnar , drbd-dev@lists.linbit.com, Kees Cook , Arnd Bergmann , Tudor-Dan Ambarus , linux-block@vger.kernel.org, Josh Poimboeuf Return-path: In-Reply-To: <1532503493.3223.0.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 25 Jul 2018 09:24:53 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org Johannes Berg writes: > On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote: >> In preparing to remove all stack VLA usage from the kernel[1], this >> removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of >> the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash >> to direct shash. By removing a layer of indirection this both improves >> performance and reduces stack usage. The stack allocation will be made >> a fixed size in a later patch to the crypto subsystem. > > I think you sent this before - it should be in net-next now. Yup, I see it in net-next: d17504b16ea2 wireless/lib80211: Convert from ahash to shash -- Kalle Valo