From: Thomas Gleixner <tglx@linutronix.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-crypto@vger.kernel.org, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH RFC v3] random: implement getrandom() in vDSO
Date: Tue, 08 Nov 2022 09:32:19 +0100 [thread overview]
Message-ID: <87v8np978s.ffs@tglx> (raw)
In-Reply-To: <20220916125916.652546-1-Jason@zx2c4.com>
On Fri, Sep 16 2022 at 13:59, Jason A. Donenfeld wrote:
> ---
> MAINTAINERS | 2 +
> arch/x86/entry/syscalls/syscall_32.tbl | 1 +
> arch/x86/entry/syscalls/syscall_64.tbl | 1 +
> arch/x86/entry/vdso/Makefile | 3 +-
> arch/x86/entry/vdso/vdso.lds.S | 2 +
> arch/x86/entry/vdso/vgetrandom.c | 16 ++++
> arch/x86/include/asm/vdso/getrandom.h | 37 ++++++++
> arch/x86/include/asm/vvar.h | 16 ++++
> drivers/char/random.c | 64 ++++++++++++++
> include/vdso/datapage.h | 6 ++
> lib/crypto/chacha.c | 4 +
> lib/vdso/getrandom.c | 117 +++++++++++++++++++++++++
> lib/vdso/getrandom.h | 25 ++++++
> 13 files changed, 293 insertions(+), 1 deletion(-)
> create mode 100644 arch/x86/entry/vdso/vgetrandom.c
> create mode 100644 arch/x86/include/asm/vdso/getrandom.h
> create mode 100644 lib/vdso/getrandom.c
> create mode 100644 lib/vdso/getrandom.h
This is not how it works. Please split this apart into reviewable bits
and pieces:
1) Add the new syscall
2) Add the vdso infrastructure
3) Wire it up on x86
Thanks,
tglx
next prev parent reply other threads:[~2022-11-08 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 12:59 [PATCH RFC v3] random: implement getrandom() in vDSO Jason A. Donenfeld
2022-11-08 8:32 ` Thomas Gleixner [this message]
2022-11-08 11:40 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8np978s.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox