From: Thomas Gleixner <tglx@linutronix.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
arnd@arndb.de, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v6 06/17] timekeeping: add raw clock fallback for random_get_entropy()
Date: Mon, 02 May 2022 11:37:46 +0200 [thread overview]
Message-ID: <87y1zkmg0l.ffs@tglx> (raw)
In-Reply-To: <YmageFiSs0h1jzS7@zx2c4.com>
On Mon, Apr 25 2022 at 15:22, Jason A. Donenfeld wrote:
> On Mon, Apr 25, 2022 at 02:37:11PM +0200, Thomas Gleixner wrote:
>> On Sat, Apr 23 2022 at 23:26, Jason A. Donenfeld wrote:
>> >
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Arnd Bergmann <arnd@arndb.de>
>> > Cc: Theodore Ts'o <tytso@mit.edu>
>> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>>
>> Not that I care much, but in general taking over authorship w/o
>> attribution via Suggested-by or such is frowned upon.
>
> Sorry about that. Usually I'm pretty good about adding those. I guess
> something must have gotten lost this time through, as the v1 of this
> started out using sched_clock() (Arnd's suggestion) and then moved to
> using the raw ktime clock after your suggestion, and I missed the
> Suggested-by. I'll add that. Meanwhile, do you want to Ack this patch?
> Do the technical aspects look okay to you?
Yes. Please fix the subject line:
timekeeping: Add raw clock fallback for random_get_entropy()
and stick the Cc's below the SOB, so it conforms with the TIP tree
rules. Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2022-05-02 9:38 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 21:26 [PATCH v6 00/17] archs/random: fallback to best raw ktime when no cycle counter Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 01/17] ia64: define get_cycles macro for arch-override Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 02/17] s390: " Jason A. Donenfeld
2022-04-25 9:43 ` Heiko Carstens
2022-04-25 9:48 ` Jason A. Donenfeld
2022-04-25 10:21 ` Heiko Carstens
2022-04-23 21:26 ` [PATCH v6 03/17] parisc: " Jason A. Donenfeld
2022-04-24 18:35 ` Helge Deller
2022-04-23 21:26 ` [PATCH v6 04/17] alpha: " Jason A. Donenfeld
2022-04-26 20:31 ` Matt Turner
2022-04-23 21:26 ` [PATCH v6 05/17] powerpc: " Jason A. Donenfeld
2022-04-28 5:19 ` Michael Ellerman
2022-04-23 21:26 ` [PATCH v6 06/17] timekeeping: add raw clock fallback for random_get_entropy() Jason A. Donenfeld
2022-04-25 12:37 ` Thomas Gleixner
2022-04-25 13:22 ` Jason A. Donenfeld
2022-05-02 9:37 ` Thomas Gleixner [this message]
2022-05-05 0:19 ` [PATCH v7] timekeeping: Add " Jason A. Donenfeld
2022-05-05 0:29 ` Jason A. Donenfeld
2022-05-06 3:20 ` [timekeeping] 3aeaac747d: PANIC:early_exception kernel test robot
2022-05-06 7:59 ` Thomas Gleixner
2022-05-06 10:12 ` Jason A. Donenfeld
2022-05-06 16:01 ` Thomas Gleixner
2022-05-06 10:21 ` [PATCH v8] timekeeping: Add raw clock fallback for random_get_entropy() Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 07/17] m68k: use fallback for random_get_entropy() instead of zero Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 08/17] riscv: " Jason A. Donenfeld
2022-04-25 14:55 ` Palmer Dabbelt
2022-04-25 15:02 ` Jason A. Donenfeld
2022-04-25 15:20 ` Palmer Dabbelt
2022-04-23 21:26 ` [PATCH v6 09/17] mips: use fallback for random_get_entropy() instead of just c0 random Jason A. Donenfeld
2022-04-26 20:28 ` Maciej W. Rozycki
2022-04-27 1:29 ` Jason A. Donenfeld
2022-06-24 13:04 ` Jason A. Donenfeld
2022-06-24 13:25 ` Maciej W. Rozycki
2022-09-25 10:00 ` Jason A. Donenfeld
2022-09-25 14:17 ` Maciej W. Rozycki
2022-04-23 21:26 ` [PATCH v6 10/17] arm: use fallback for random_get_entropy() instead of zero Jason A. Donenfeld
2022-04-25 14:30 ` Russell King (Oracle)
2022-04-23 21:26 ` [PATCH v6 11/17] openrisc: " Jason A. Donenfeld
2022-04-27 21:42 ` Stafford Horne
2022-04-27 23:26 ` Jason A. Donenfeld
2022-04-29 0:16 ` [PATCH v7 11/17] openrisc: account for 0 starting value in random_get_entropy() Jason A. Donenfeld
2022-04-30 1:19 ` Stafford Horne
2022-04-30 1:29 ` Jason A. Donenfeld
2022-04-30 22:11 ` Stafford Horne
2022-04-30 22:34 ` Jason A. Donenfeld
2022-04-30 22:44 ` Stafford Horne
2022-04-23 21:26 ` [PATCH v6 12/17] nios2: use fallback for random_get_entropy() instead of zero Jason A. Donenfeld
2022-05-23 13:56 ` Dinh Nguyen
2022-04-23 21:26 ` [PATCH v6 13/17] x86: " Jason A. Donenfeld
2022-04-25 12:35 ` Thomas Gleixner
2022-04-25 13:41 ` Jason A. Donenfeld
2022-04-25 13:51 ` Jason A. Donenfeld
2022-04-25 17:03 ` Thomas Gleixner
2022-04-25 17:24 ` Jason A. Donenfeld
2022-04-26 8:33 ` [PATCH v7 13/17] x86/asm: " Jason A. Donenfeld
2022-05-02 9:40 ` Thomas Gleixner
2022-04-23 21:26 ` [PATCH v6 14/17] um: " Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 15/17] sparc: " Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 16/17] xtensa: " Jason A. Donenfeld
2022-04-23 21:26 ` [PATCH v6 17/17] random: insist on random_get_entropy() existing in order to simplify Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1zkmg0l.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).