From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mx1.zhaoxin.com (MX1.ZHAOXIN.COM [210.0.225.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D773CC2 for ; Fri, 17 Nov 2023 03:19:26 -0800 (PST) X-ASG-Debug-ID: 1700219962-086e236ff01f4d0001-Xm9f1P Received: from ZXSHMBX3.zhaoxin.com (ZXSHMBX3.zhaoxin.com [10.28.252.165]) by mx1.zhaoxin.com with ESMTP id lmhIwENaRer50217 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 17 Nov 2023 19:19:22 +0800 (CST) X-Barracuda-Envelope-From: LeoLiu-oc@zhaoxin.com X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.165 Received: from ZXBJMBX03.zhaoxin.com (10.29.252.7) by ZXSHMBX3.zhaoxin.com (10.28.252.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 17 Nov 2023 19:19:21 +0800 Received: from [192.168.1.204] (125.76.214.122) by ZXBJMBX03.zhaoxin.com (10.29.252.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 17 Nov 2023 19:19:20 +0800 X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.165 Message-ID: <88075c49-8118-4c4b-a2ce-e460180fa30c@zhaoxin.com> X-Barracuda-RBL-Trusted-Forwarder: 192.168.1.204 Date: Fri, 17 Nov 2023 19:19:19 +0800 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction To: Herbert Xu X-ASG-Orig-Subj: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction CC: , , , , , , , , , , , References: <20231107070900.496827-1-LeoLiu-oc@zhaoxin.com> <20231108073454.521726-1-LeoLiu-oc@zhaoxin.com> From: LeoLiu-oc In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [125.76.214.122] X-ClientProxiedBy: ZXSHCAS1.zhaoxin.com (10.28.252.161) To ZXBJMBX03.zhaoxin.com (10.29.252.7) X-Barracuda-Connect: ZXSHMBX3.zhaoxin.com[10.28.252.165] X-Barracuda-Start-Time: 1700219962 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://10.28.252.35:4443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at zhaoxin.com X-Barracuda-Scan-Msg-Size: 1222 X-Barracuda-BRTS-Status: 0 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=MAILTO_TO_SPAM_ADDR X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.116869 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 MAILTO_TO_SPAM_ADDR Includes a link to a likely spammer email 在 2023/11/17 18:35, Herbert Xu 写道: > On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote: >> From: LeoLiuoc >> >> Add support for Zhaoxin hardware random number generator. >> This driver base on rep_xstore instruction and uses the same >> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id >> array in the via-rng driver, so that the corresponding driver can be >> correctly loader on respective platforms. >> >> --- >> >> v1 -> v2: >> 1. Fix assembler code errors >> 2. Remove redundant CPU model check codes >> >> Signed-off-by: LeoLiuoc >> --- >> drivers/char/hw_random/Kconfig | 13 ++++ >> drivers/char/hw_random/Makefile | 1 + >> drivers/char/hw_random/via-rng.c | 23 +++---- >> drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++ >> 4 files changed, 119 insertions(+), 13 deletions(-) >> create mode 100644 drivers/char/hw_random/zhaoxin-rng.c > > Please cc x86@vger.kernel.org as the same comments to the other > zhaoxin driver seems to be applicable here. > > Thanks, Okay, Will re-send v2 add cc x86@vger.kernel.org. Best Regards Leoliu-oc