From: "H. Peter Anvin" <hpa@zytor.com>
To: Denys Vlasenko <dvlasenk@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Xiaodong Liu <xiaodong.liu@intel.com>,
Megha Dey <megha.dey@intel.com>,
George Spelvin <linux@horizon.com>,
linux-crypto@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits
Date: Wed, 25 Jan 2017 14:37:08 -0800 [thread overview]
Message-ID: <8ad0ec8d-a7d2-b4ca-df7d-3b670b468baf@zytor.com> (raw)
In-Reply-To: <20170119212805.18049-1-dvlasenk@redhat.com>
On 01/19/17 13:28, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
>
> x86 consistently uses @progbits everywhere else.
However, it looks like %progbits works on all architectures (at least
include/linux/init.h seems to imply so.) Perhaps a tree-wide
replacement the other way would make more sense.
Personally I would also like to see these parameters macroized, to keep
someone from getting them wrong, just like we have __INIT, __INITRODATA
etc already, we should just have plain __TEXT __DATA __BSS...
-hpa
prev parent reply other threads:[~2017-01-25 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:28 [PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko
2017-01-19 21:32 ` Josh Poimboeuf
2017-01-23 15:00 ` Herbert Xu
2017-01-25 22:37 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad0ec8d-a7d2-b4ca-df7d-3b670b468baf@zytor.com \
--to=hpa@zytor.com \
--cc=dvlasenk@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jpoimboe@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=megha.dey@intel.com \
--cc=x86@kernel.org \
--cc=xiaodong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox