From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mike Frysinger" Subject: Re: [2.6 patch] add include/asm-avr32/xor.h Date: Mon, 14 Apr 2008 18:30:47 -0400 Message-ID: <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com> References: <20080414141632.GA6695@cs181133002.pp.htv.fi> <20080414181140.GA813@Chamillionaire.breakpoint.cc> <20080414181536.GZ6695@cs181133002.pp.htv.fi> <20080414214640.GA2282@Chamillionaire.breakpoint.cc> <20080414220129.GH26885@cs181133002.pp.htv.fi> <8bd0f97a0804141511o28385fcfl11923148f7fe701a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Adrian Bunk" , "Sebastian Siewior" , hskinnemoen@atmel.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@intel.com To: "Dan Williams" Return-path: Received: from wr-out-0506.google.com ([64.233.184.231]:41270 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbYDNWat (ORCPT ); Mon, 14 Apr 2008 18:30:49 -0400 Received: by wr-out-0506.google.com with SMTP id c48so1002325wra.1 for ; Mon, 14 Apr 2008 15:30:48 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams wrote: > On Mon, Apr 14, 2008 at 3:11 PM, Mike Frysinger wrote: > > On Mon, Apr 14, 2008 at 6:01 PM, Adrian Bunk wrote: > > > On Mon, Apr 14, 2008 at 11:46:40PM +0200, Sebastian Siewior wrote: > > > > so most > > > > xor.h files are identical copies and this is probably as bad as a > > > > trailing white space :) > > > > > > I'm not sure whether it's worth spending my time discussing whether > > > adding a config variable to 6 architectures is really better than > > > adding trivial headers to 3 architectures... > > > > long term robustness for new ports/codedrops indicates that having a > > common header in linux/ and making arches opt-in via Kconfig/whatever > > makes life a lot easier for everyone > > > > everything builds by default with the generic C versions and arches > > dont have to go through and figure out all the fun little stub files > > they need to straight copy from other architectures ... they only have > > to care if they want to implement an optimized version > > "arches" did not have to go through and figure out the fun little stub > file for xor.h. Adrian already made your "life easier". actually he didnt. he posted a fix for avr32. i dont care about avr32, i'm a blackfin guy. he also wouldnt have had to do anything at all if everything was handled with indirection in linux/xor.h. your point also is irrelevant in the case of new architectures. poor microblaze for example. -mike