Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Anatoly Pugachev <matorola@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, sparclinux@vger.kernel.org,
	Nicolai Stange <nicstange@gmail.com>
Subject: Re: [crypto / sparc64] cryptomgr_test OOPS
Date: Thu, 5 May 2016 09:09:10 -0700	[thread overview]
Message-ID: <909d04e6-03a7-462a-8a3f-d110bf98a865@intel.com> (raw)
In-Reply-To: <CADxRZqzyZgG=e-6aPcHrEopq51nqoU0NqdMnRcCUWkw39XB56A@mail.gmail.com>

On 05/05/2016 08:31 AM, Anatoly Pugachev wrote:
> On Thu, May 5, 2016 at 6:00 PM, Tadeusz Struk <tadeusz.struk@intel.com> wrote:
>> On 05/05/2016 02:40 AM, Anatoly Pugachev wrote:
>>> sure, based on your cryptodev git, just tried 4.3 (6a13feb , good)
>>> kernel in attempt to find (bisect) when RSA code break, already tested
>>> 4.5 (44d1b6d , bad) , 4.4 (afd2ff9 , bad).
>>> Going to try your patch soon (when I'm back home).
>>> So far 4.3 passes RSA stage without OOPS, but for other reason does
>>> not boot to login prompt. Boot log exempt (4.3), this is with
>>> CONFIG_CRYPTO_RSA=y :
>>
>> Anatoly, could you also give this a try please:
>> Thanks
>>
>> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
>> index b86883a..770970ff 100644
>> --- a/crypto/testmgr.c
>> +++ b/crypto/testmgr.c
>> @@ -1805,8 +1805,8 @@ static int do_test_rsa(struct crypto_akcipher *tfm,
>>                 goto free_req;
>>
>>         sg_init_table(src_tab, 2);
>> -       sg_set_buf(&src_tab[0], vecs->m, 8);
>> -       sg_set_buf(&src_tab[1], vecs->m + 8, vecs->m_size - 8);
>> +       sg_set_buf(&src_tab[0], vecs->m, 4);
>> +       sg_set_buf(&src_tab[1], vecs->m + 4, vecs->m_size - 4);
>>         sg_init_one(&dst, outbuf_enc, out_len_max);
>>         akcipher_request_set_crypt(req, src_tab, &dst, vecs->m_size,
>>                                    out_len_max);
> 
> 
> Tadeusz,
> 
> do you still want to test it , after I have reported that Herbert patch works?
> 

Hi Anatoly,
Since Herbert's patch fixes it for you here is no need to test this one.
Thanks,
-- 
TS

  parent reply	other threads:[~2016-05-05 16:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 13:54 [crypto / sparc64] cryptomgr_test OOPS Anatoly Pugachev
2016-05-03 16:33 ` David Miller
2016-05-04  4:07   ` Herbert Xu
2016-05-04 14:49     ` Anatoly Pugachev
2016-05-05  8:42       ` Herbert Xu
2016-05-05  9:40         ` Anatoly Pugachev
2016-05-05  9:50           ` Herbert Xu
2016-05-05 16:17             ` Tadeusz Struk
2016-05-05 15:00           ` Tadeusz Struk
2016-05-05 15:31             ` Anatoly Pugachev
2016-05-05 15:52               ` John Paul Adrian Glaubitz
2016-05-05 16:09               ` Tadeusz Struk [this message]
2016-05-05 15:12         ` Anatoly Pugachev
2016-05-05 15:17           ` John Paul Adrian Glaubitz
2016-05-06 19:52         ` David Miller
2016-05-04 19:10   ` Anatoly Pugachev
2016-05-04 20:02     ` Tadeusz Struk
2016-05-04 20:51     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=909d04e6-03a7-462a-8a3f-d110bf98a865@intel.com \
    --to=tadeusz.struk@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=matorola@gmail.com \
    --cc=nicstange@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox