From: David Howells <dhowells@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
keyrings@linux-nfs.org, linux-crypto@vger.kernel.org,
David Safford <safford@watson.ibm.com>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [RFC][PATCH 1/4] lib: hex2bin converts ascii hexadecimal string to binary
Date: Wed, 29 Sep 2010 13:11:03 +0100 [thread overview]
Message-ID: <9444.1285762263@redhat.com> (raw)
In-Reply-To: <1285698993-16927-2-git-send-email-zohar@linux.vnet.ibm.com>
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> --- a/lib/hexdump.c
> +++ b/lib/hexdump.c
> @@ -34,6 +34,22 @@ int hex_to_bin(char ch)
> EXPORT_SYMBOL(hex_to_bin);
>
> /**
> + * hex2bin - convert an ascii hexadecimal string to its binary representation
> + * @mem: result
> + * @buf: ascii hexadecimal string
> + * @count: result length
> + */
> +void hex2bin(unsigned char *mem, char *buf, int count)
Hmmm... It might be better to put this in its own file in lib, otherwise it
will drag in all the other functions in that file if used, and vice versa.
David
next prev parent reply other threads:[~2010-09-29 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 18:36 [RFC][PATCH 0/4] keys: trusted and encrypted keys Mimi Zohar
2010-09-28 18:36 ` [RFC][PATCH 1/4] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
2010-09-28 18:36 ` [RFC][PATCH 2/4] key: add tpm_send command Mimi Zohar
2010-09-28 18:36 ` [RFC][PATCH 3/4] keys: add new trusted key-type Mimi Zohar
2010-09-28 18:36 ` [RFC][PATCH 4/4] keys: add new key-type encrypted Mimi Zohar
2010-09-29 10:00 ` Roberto Sassu
2010-09-29 11:57 ` Mimi Zohar
2010-09-29 12:40 ` Roberto Sassu
2010-09-29 13:43 ` Mimi Zohar
2010-09-29 12:11 ` David Howells [this message]
2010-09-29 13:51 ` [RFC][PATCH 1/4] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9444.1285762263@redhat.com \
--to=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).