From: Stephan Mueller <smueller@chronox.de>
To: David Howells <dhowells@redhat.com>
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] DH support: add KDF handling support
Date: Wed, 27 Jul 2016 11:11:53 +0200 [thread overview]
Message-ID: <9486547.FUb4ORn15o@tauon.atsec.com> (raw)
In-Reply-To: <9263.1469606131@warthog.procyon.org.uk>
Am Mittwoch, 27. Juli 2016, 08:55:31 CEST schrieb David Howells:
Hi David,
> Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
> > > Though, shall I stuff the wrapper code back into the existing dh_compute
> > > functions or can I leave them as separate functions?
> >
> > I'm not sure. In the existing code there's one keyctl wrapper per keyctl
> > command. A combined wrapper would need some extra logic to decide whether
> > kdfparams is passed in or not, which is different from existing code.
>
> You shouldn't change the existing keyctl wrappers. Feel free to add another
> one with extra arguments.
I created dh_compute_kdf and dh_compute_kdf_oi where the latter takes the
other information from STDIN.
>
> David
Ciao
Stephan
next prev parent reply other threads:[~2016-07-27 9:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 9:06 [RFC PATCH] KEYS: add SP800-56A KDF support for DH Stephan Mueller
2016-07-12 9:06 ` [PATCH v3 0/4] crypto: Key Derivation Function (SP800-108) Stephan Mueller
2016-07-12 9:07 ` [PATCH v3 1/4] crypto: add template handling for RNGs Stephan Mueller
2016-07-18 7:14 ` Herbert Xu
2016-07-18 7:18 ` Stephan Mueller
2016-07-18 15:23 ` Sandy Harris
2016-07-18 15:37 ` Stephan Mueller
2016-07-12 9:07 ` [PATCH v3 2/4] crypto: kdf - add known answer tests Stephan Mueller
2016-07-12 9:07 ` [PATCH v3 3/4] crypto: kdf - SP800-108 Key Derivation Function Stephan Mueller
2016-07-12 9:08 ` [PATCH v3 4/4] crypto: kdf - enable compilation Stephan Mueller
2016-07-12 9:08 ` [PATCH] DH support: add KDF handling support Stephan Mueller
2016-07-13 23:17 ` Mat Martineau
2016-07-14 6:54 ` Stephan Mueller
2016-07-14 8:00 ` Jeffrey Walton
2016-07-14 14:19 ` Stephan Mueller
2016-07-14 23:47 ` Mat Martineau
2016-07-27 7:55 ` David Howells
2016-07-27 9:11 ` Stephan Mueller [this message]
2016-07-15 0:45 ` [RFC PATCH] KEYS: add SP800-56A KDF support for DH Mat Martineau
2016-07-15 16:38 ` Stephan Mueller
2016-07-15 18:45 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9486547.FUb4ORn15o@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).