From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD212EB64D7 for ; Tue, 20 Jun 2023 16:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbjFTQ7a (ORCPT ); Tue, 20 Jun 2023 12:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbjFTQ73 (ORCPT ); Tue, 20 Jun 2023 12:59:29 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8010E68 for ; Tue, 20 Jun 2023 09:59:27 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3113306a595so3716576f8f.1 for ; Tue, 20 Jun 2023 09:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1687280366; x=1689872366; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iFGev71zOSbUwc9Ipdme/ZAxUB7isGkByEQJ4BO7RuU=; b=csYtTXyre+3fJAdfsJmH5x4q253rZjhqSL6nkUR9EbWvn0z4eQn99DEpJcvyMz/N2B xvG4xNctd5VW6P54WYaxari2Ksw/Ave6KKjVIMOXWEjYwEp4EAgNGjbI2i4/r1VBbRkj XG2G6E50aTAUO1Y4YwUKTkNyDt7N3bTtRJzVzkoN/Fu0OYTxCfnna5U9lKomemVvAKqx 2iJAdKjqb5jcsva8gs+2WF9d4HVAcC6DdkSDx051c+yZRtucnwVj+2KL1P+A/FyU7uzA U8zci+DmIAG6SJMR1QdzgOcLgS5VjIf4SXO0+XMjNhliHWaFN92HkwPt+gKTDJ1QnyfB VUmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687280366; x=1689872366; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iFGev71zOSbUwc9Ipdme/ZAxUB7isGkByEQJ4BO7RuU=; b=E3HTf7b0ukf9RPB7zD2USFN/5Li1K3p7jArlUjLWbWJL76EG90ILQextnZ0oMSNfOT rr9AIXbHa5H3s2ttLreWLa9hetn5+knglLdpl1CAO583Xz6m98qqqiC5fobAmWozyNS+ 3QrEZMwHlWx5X7x/Qmve6mThkXsN4VNFHxR/9h4FCWPbGBtnImL+x8Spgc3koyVpYivG xJi10BCCwGVH5uTXpKjAAp0iWl0z+oRBpwHVmwLpzsF5uxVZ3vqscPOX/BWyb2PLCB8m q9N+wih9Sim1y8FpTssUR2zp3Xb0Oo18uayDUG+kxwoujffMV3jKCke7ZQcSzFe0cRLk lbVg== X-Gm-Message-State: AC+VfDwUI1LsPzd6KFgBuLphEXKzhXkjSSqoo1er2/ZdxeI0Sr/QGpI6 47B1WbetS7g4XXjA2qxL6zuNBQ== X-Google-Smtp-Source: ACHHUZ4Od9jnD8B4wGHwa48B70g3JbHTkdUhQakX8BFWBVnF3ui5jOimXG0SRMmf1h+Z4StEnd5Prw== X-Received: by 2002:adf:e848:0:b0:311:15ae:2cd2 with SMTP id d8-20020adfe848000000b0031115ae2cd2mr12172066wrn.15.1687280366354; Tue, 20 Jun 2023 09:59:26 -0700 (PDT) Received: from [10.83.37.24] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id t13-20020adff60d000000b003119633ecb5sm2364328wrp.88.2023.06.20.09.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 09:59:25 -0700 (PDT) Message-ID: <973f8619-15ff-608e-250b-356f5c140a2a@arista.com> Date: Tue, 20 Jun 2023 17:59:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [v2 PATCH] crypto: api - Add __crypto_alloc_tfmgfp Content-Language: en-US To: Herbert Xu Cc: linux-kernel@vger.kernel.org, Bob Gilligan , David Ahern , "David S. Miller" , Dmitry Safonov <0x7f454c46@gmail.com>, Eric Dumazet , "Eric W. Biederman" , Francesco Ruggeri , Jakub Kicinski , Paolo Abeni , Salam Noureddine , linux-crypto@vger.kernel.org References: <20230614174643.3836590-1-dima@arista.com> <20230614174643.3836590-3-dima@arista.com> <6aa4521f-e5d2-ed12-ab49-1132409ab358@arista.com> From: Dmitry Safonov In-Reply-To: <6aa4521f-e5d2-ed12-ab49-1132409ab358@arista.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Herbert, On 6/15/23 17:19, Dmitry Safonov wrote: > On 6/15/23 10:00, Herbert Xu wrote: > [..] >> >> Good catch. Though I'd rather add the gfp argument to a separate >> function because I'm in the process of replacing ciphers with >> something that uses the new crypto_types API. >> >> Once that happens ciphers will switch over to the normal cloning >> call and this can be removed. > > LGTM, thanks! Would you prefer me to resend this v2 or you're happy to apply with your proposed changes? >> ---8<--- >> Use it straight away in crypto_clone_cipher(), as that is not meant to >> sleep. >> >> Fixes: 51d8d6d0f4be ("crypto: cipher - Add crypto_clone_cipher") >> Signed-off-by: Dmitry Safonov >> Signed-off-by: Herbert Xu >> >> diff --git a/crypto/api.c b/crypto/api.c > [..] Thanks, Dmitry