linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: s5p-sss - Remove a stray tab
@ 2017-11-09 21:26 Dan Carpenter
  2017-11-10  8:08 ` Krzysztof Kozlowski
  2017-11-29  6:31 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-11-09 21:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kamil Konieczny
  Cc: Vladimir Zapolskiy, Herbert Xu, David S. Miller, linux-crypto,
	linux-samsung-soc, kernel-janitors

This code seems correct, but the goto was indented too far.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 142c6020cec7..62830a43d959 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -1461,7 +1461,7 @@ static void s5p_hash_tasklet_cb(unsigned long data)
 				       &dd->hash_flags)) {
 			/* hash or semi-hash ready */
 			clear_bit(HASH_FLAGS_DMA_READY, &dd->hash_flags);
-				goto finish;
+			goto finish;
 		}
 	}
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: s5p-sss - Remove a stray tab
  2017-11-09 21:26 [PATCH] crypto: s5p-sss - Remove a stray tab Dan Carpenter
@ 2017-11-10  8:08 ` Krzysztof Kozlowski
  2017-11-29  6:31 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2017-11-10  8:08 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Kamil Konieczny, Vladimir Zapolskiy, Herbert Xu, David S. Miller,
	linux-crypto, linux-samsung-soc, kernel-janitors

On Thu, Nov 9, 2017 at 10:26 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code seems correct, but the goto was indented too far.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: s5p-sss - Remove a stray tab
  2017-11-09 21:26 [PATCH] crypto: s5p-sss - Remove a stray tab Dan Carpenter
  2017-11-10  8:08 ` Krzysztof Kozlowski
@ 2017-11-29  6:31 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-11-29  6:31 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Krzysztof Kozlowski, Kamil Konieczny, Vladimir Zapolskiy,
	David S. Miller, linux-crypto, linux-samsung-soc, kernel-janitors

On Fri, Nov 10, 2017 at 12:26:04AM +0300, Dan Carpenter wrote:
> This code seems correct, but the goto was indented too far.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-29  6:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-09 21:26 [PATCH] crypto: s5p-sss - Remove a stray tab Dan Carpenter
2017-11-10  8:08 ` Krzysztof Kozlowski
2017-11-29  6:31 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).