From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"steve.capper@linaro.org" <steve.capper@linaro.org>
Subject: Re: [PATCH resend 00/15] arm64 crypto roundup
Date: Fri, 9 May 2014 08:37:58 +0200 [thread overview]
Message-ID: <CAKv+Gu8iYzPUWfwLJJtPCGWKROV5EKSP-NA90F+PyVecorOL9g@mail.gmail.com> (raw)
In-Reply-To: <760C2409-2C8F-45B7-8EC0-220545D0B51B@arm.com>
On 8 May 2014 23:50, Catalin Marinas <catalin.marinas@arm.com> wrote:
> On 8 May 2014, at 12:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> On 7 May 2014 16:45, Catalin Marinas <catalin.marinas@arm.com> wrote:
>>> On Thu, May 01, 2014 at 04:49:32PM +0100, Ard Biesheuvel wrote:
>>>> This is a repost of the arm64 crypto patches that I have posted to the LAKML
>>>> over the past months. They have now been verified on actual hardware
>>>> (Cortex-A57) so if there are no remaining issues I would like to propose them
>>>> for 3.16.
>>>>
>>>> Ard Biesheuvel (15):
>>>> asm-generic: allow generic unaligned access if the arch supports it
>>>> arm64: add abstractions for FPSIMD state manipulation
>>>> arm64: defer reloading a task's FPSIMD state to userland resume
>>>> arm64: add support for kernel mode NEON in interrupt context
>>>> arm64/crypto: SHA-1 using ARMv8 Crypto Extensions
>>>> arm64/crypto: SHA-224/SHA-256 using ARMv8 Crypto Extensions
>>>> arm64/crypto: GHASH secure hash using ARMv8 Crypto Extensions
>>>> arm64/crypto: AES using ARMv8 Crypto Extensions
>>>> arm64/crypto: AES in CCM mode using ARMv8 Crypto Extensions
>>>> arm64: pull in <asm/simd.h> from asm-generic
>>>> arm64/crypto: AES-ECB/CBC/CTR/XTS using ARMv8 NEON and Crypto
>>>> Extensions
>>>> arm64/crypto: add shared macro to test for NEED_RESCHED
>>>> arm64/crypto: add voluntary preemption to Crypto Extensions SHA1
>>>> arm64/crypto: add voluntary preemption to Crypto Extensions SHA2
>>>> arm64/crypto: add voluntary preemption to Crypto Extensions GHASH
>>>
>>> There are about 5 patches that make sense to me ;) and apart from a few
>>> minor comments they look fine.
>>>
>>> There are the other 10 crypto patches that are beyond my knowledge. Do
>>> you know anyone who could do a sanity check on them? Are there any tests
>>> that would show the correctness of the implementation?
>>
>> I will re-send the 3 FPSIMD patches separately with your review
>> comments addressed.
>
> Thanks. If you get another acked/reviewed-by tag on the rest of the
> patches it’s even better (I plan to get the series in for 3.16, after
> we do some tests internally as well).
>
@Herbert, Jussi: care to share your opinion on the SHAx, GHASH and AES
patches above? Herbert has already acked the ccm patch, but Catalin is
requesting for more review and/or acknowledgements before merging
these patches for arm64.
Regards,
Ard.
next prev parent reply other threads:[~2014-05-09 6:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 15:49 [PATCH resend 00/15] arm64 crypto roundup Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 01/15] asm-generic: allow generic unaligned access if the arch supports it Ard Biesheuvel
2014-05-06 14:31 ` Catalin Marinas
2014-05-06 14:34 ` Ard Biesheuvel
2014-05-06 15:14 ` Catalin Marinas
2014-05-01 15:49 ` [PATCH resend 02/15] arm64: add abstractions for FPSIMD state manipulation Ard Biesheuvel
2014-05-06 14:43 ` Catalin Marinas
2014-05-06 14:48 ` Ard Biesheuvel
2014-05-06 15:12 ` Catalin Marinas
2014-05-06 15:42 ` Catalin Marinas
2014-05-01 15:49 ` [PATCH resend 03/15] arm64: defer reloading a task's FPSIMD state to userland resume Ard Biesheuvel
2014-05-06 16:08 ` Catalin Marinas
2014-05-06 16:25 ` Ard Biesheuvel
2014-05-06 16:31 ` Catalin Marinas
2014-05-01 15:49 ` [PATCH resend 04/15] arm64: add support for kernel mode NEON in interrupt context Ard Biesheuvel
2014-05-06 16:49 ` Catalin Marinas
2014-05-06 17:09 ` Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 05/15] arm64/crypto: SHA-1 using ARMv8 Crypto Extensions Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 06/15] arm64/crypto: SHA-224/SHA-256 " Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 07/15] arm64/crypto: GHASH secure hash " Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 08/15] arm64/crypto: AES " Ard Biesheuvel
2014-05-01 15:49 ` [PATCH resend 09/15] arm64/crypto: AES in CCM mode " Ard Biesheuvel
2014-05-07 14:45 ` [PATCH resend 00/15] arm64 crypto roundup Catalin Marinas
2014-05-07 19:58 ` Ard Biesheuvel
2014-05-08 11:22 ` Ard Biesheuvel
2014-05-08 21:50 ` Catalin Marinas
2014-05-09 6:37 ` Ard Biesheuvel [this message]
2014-05-14 1:29 ` Herbert Xu
2014-05-14 8:47 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8iYzPUWfwLJJtPCGWKROV5EKSP-NA90F+PyVecorOL9g@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).