From: Fabio Estevam <festevam@gmail.com>
To: Mogens Lauridsen <mlauridsen171@gmail.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: Fix dma unmap direction in iMX sahara aes calculation
Date: Tue, 25 Jul 2017 14:51:11 -0300 [thread overview]
Message-ID: <CAOMZO5Dc4EG8ipGnBSVbJRp9QTBKMVTmXPbambMSfvHWzYVWJQ@mail.gmail.com> (raw)
In-Reply-To: <CACA-NJv69LnyR-xcJC8OU-_WRfg1Mtawq9UapswQczrdAonFDA@mail.gmail.com>
Hi Mogens,
On Sun, Jul 16, 2017 at 6:21 PM, Mogens Lauridsen
<mlauridsen171@gmail.com> wrote:
> Hi,
>
> The direction used in dma_unmap_sg in aes calc in sahara.c is wrong.
> This result in the cache not being invalidated correct when aes
> calculation is done and result is dma'ed to memory.
> This is seen as sporadic wrong result from aes calc.
>
> Thanks,
> Mogens
>
> Signed-off-by: Mogens Lauridsen <mlauridsen171@gmail.com>
Your two fixes are good, but the patch format is not correct.
You could try to use git send-email for submitting the two patches.
Subject could be improved. If you run 'git log
drivers/crypto/sahara.c' you will see the common standard, so you
could do:
crypto: sahara - Fix dma unmap direction as the Subject.
Then you need to run './scripts/checkpatch.pl 0001-your.patch' to see
what people and lists to send it to.
Please resend them.
next prev parent reply other threads:[~2017-07-25 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 21:21 Fix dma unmap direction in iMX sahara aes calculation Mogens Lauridsen
2017-07-25 17:51 ` Fabio Estevam [this message]
2017-07-28 9:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5Dc4EG8ipGnBSVbJRp9QTBKMVTmXPbambMSfvHWzYVWJQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=mlauridsen171@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).