Fix dma unmap direction in iMX sahara aes calculation

Fix dma unmap direction in iMX sahara aes calculation

[Mogens Lauridsen]

Hi,

The direction used in dma_unmap_sg in aes calc in sahara.c is wrong.
This result in the cache not being invalidated correct when aes
calculation is done and result is dma'ed to memory.
This is seen as sporadic wrong result from aes calc.

Thanks,
Mogens

Signed-off-by: Mogens Lauridsen <mlauridsen171@gmail.com>

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 1d9ecd3..9538c52 100644ae
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -543,10 +543,10 @@ static int sahara_hw_descriptor_create(struct sahara_dev *

 unmap_out:
        dma_unmap_sg(dev->device, dev->out_sg, dev->nb_out_sg,
-               DMA_TO_DEVICE);
+               DMA_FROM_DEVICE);
 unmap_in:
        dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg,
-               DMA_FROM_DEVICE);
+               DMA_TO_DEVICE);

        return -EINVAL;
 }
@@ -594,9 +594,9 @@ static int sahara_aes_process(struct ablkcipher_request *req
        }

        dma_unmap_sg(dev->device, dev->out_sg, dev->nb_out_sg,
-               DMA_TO_DEVICE);
-       dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg,
                DMA_FROM_DEVICE);
+       dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg,
+               DMA_TO_DEVICE);

        return 0;
 }

Re: Fix dma unmap direction in iMX sahara aes calculation

[Fabio Estevam]

Hi Mogens,

On Sun, Jul 16, 2017 at 6:21 PM, Mogens Lauridsen
<mlauridsen171@gmail.com> wrote:
> Hi,
>
> The direction used in dma_unmap_sg in aes calc in sahara.c is wrong.
> This result in the cache not being invalidated correct when aes
> calculation is done and result is dma'ed to memory.
> This is seen as sporadic wrong result from aes calc.
>
> Thanks,
> Mogens
>
> Signed-off-by: Mogens Lauridsen <mlauridsen171@gmail.com>

Your two fixes are good, but the patch format is not correct.

You could try to use git send-email for submitting the two patches.

Subject could be improved. If you run 'git log
drivers/crypto/sahara.c' you will see the common standard, so you
could do:

crypto: sahara - Fix dma unmap direction as the Subject.

Then you need to run './scripts/checkpatch.pl 0001-your.patch' to see
what people and lists to send it to.

Please resend them.

Re: Fix dma unmap direction in iMX sahara aes calculation

[Herbert Xu]

Mogens Lauridsen <mlauridsen171@gmail.com> wrote:
> Hi,
> 
> The direction used in dma_unmap_sg in aes calc in sahara.c is wrong.
> This result in the cache not being invalidated correct when aes
> calculation is done and result is dma'ed to memory.
> This is seen as sporadic wrong result from aes calc.
> 
> Thanks,
> Mogens
> 
> Signed-off-by: Mogens Lauridsen <mlauridsen171@gmail.com>
> 
> diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
> index 1d9ecd3..9538c52 100644ae
> --- a/drivers/crypto/sahara.c
> +++ b/drivers/crypto/sahara.c
> @@ -543,10 +543,10 @@ static int sahara_hw_descriptor_create(struct sahara_dev *
> 
> unmap_out:
>        dma_unmap_sg(dev->device, dev->out_sg, dev->nb_out_sg,
> -               DMA_TO_DEVICE);
> +               DMA_FROM_DEVICE);

Your patch is space-damaged and does not apply.  Please send your
emails in a way that preserves white spaces.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt