Re: [PATCH v3 1/2] certs: Move RSA self-test data to separate file

["Jarkko Sakkinen" <jarkko@kernel.org>]

On Fri May 10, 2024 at 11:15 AM EEST, Herbert Xu wrote:
> On Thu, May 02, 2024 at 11:38:56PM -0500, Joachim Vandersmissen wrote:
> >
> > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> > index 59ec726b7c77..68434c745b3c 100644
> > --- a/crypto/asymmetric_keys/Kconfig
> > +++ b/crypto/asymmetric_keys/Kconfig
> > @@ -86,4 +86,14 @@ config FIPS_SIGNATURE_SELFTEST
> >  	depends on PKCS7_MESSAGE_PARSER=X509_CERTIFICATE_PARSER
> >  	depends on X509_CERTIFICATE_PARSER
> >  
> > +config FIPS_SIGNATURE_SELFTEST_RSA
> > +	bool "Include RSA selftests"
>
> Please don't ask questinons in Kconfig that we can avoid.  In
> this case I see no valid reason for having this extra knob.
>
> One question for FIPS_SIGNATURE_SELFTEST is enough.
>
> Oh and please cc Jarkko Sakkinen <jarkko@kernel.org> since he
> picked up two earlier fixes for this and it's best if this went
> through his tree.
>
> Thanks,

Fine with me. I've yet to send asymmetric keys pull request (last
remaining) so there is some window left too.

BR, Jarkko