From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5C7187355; Wed, 11 Sep 2024 11:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726055553; cv=none; b=nFFMoKCQTROt1A5Xlf9XAca+oB4+P4CMRXBm3bf36kPkl8s+gjXL299p5QPqw0SYF3HyeGZRTtOTI/g3o6WuwOSsZNZ/XPFhKOODsrpC4zxfBCwrwbGZkUvOd2Wpy573zRWsBLV5/bRSGHbK9az9c2BCHLKfsCX+sVF7K8npGD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726055553; c=relaxed/simple; bh=m2G9sU3dDk87vO6dqG2X29ztnbBK8oLK3pr8htXdlTc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Qs5wB3kPtldjhwwl4Wd0/HKu/PxAkYT291DXxbYfgQYRhlKk+9f7OOBverYJDlr/2EG50kqsOf73ysn3dCi28QYEdETqBRhkLYnpiuIlOefEhazHKEivOumyW+PJm1YiwdtgNzApPpRyOnA8shd8tFuBd5Req+vCXqDYU1sR1IA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eBDzK1FL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eBDzK1FL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BAB5C4CEC5; Wed, 11 Sep 2024 11:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726055551; bh=m2G9sU3dDk87vO6dqG2X29ztnbBK8oLK3pr8htXdlTc=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=eBDzK1FLiKyQUBq6ltFE1xDrd+5xd6+bav8ODjz8WyuL91LQxi9qBufXH1h46JfJW un90y3GSg5YSGNuAiD6MDd95eTXaDj9xZgtjByZFjtY8PNC0F0bxbG/J5HcuIR6MWO 7OlA6AOFhLJ9QhmNs0+XkSmRDUpMMKmlehmDZL8yZuEiOd8nq/ECMBUGVafkXhTs77 w5/gOcgqZO37BC0SXYNPCK057K021ECGhnRaJFkhDV8A7Wege/vl8CMAM8R7S3Gl4x d8iYiSWWCSHEvn/KsW732uPIYUPqXKvgHfxZfDipDhuv3qMJyWNd7GmykS382Gue7E 59SEDy6K5/mFA== Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 11 Sep 2024 14:52:27 +0300 Message-Id: Cc: "David Howells" , "Andrew Zaborowski" , "Saulo Alessandre" , "Jonathan Cameron" , "Ignat Korchagin" , "Marek Behun" , "Varad Gautam" , "Stephan Mueller" , "Denis Kenzior" , , Subject: Re: [PATCH v2 01/19] crypto: ecdsa - Drop unused test vector elements From: "Jarkko Sakkinen" To: "Lukas Wunner" , "Herbert Xu" , "David S. Miller" , "Eric Biggers" , "Stefan Berger" , "Vitaly Chikunov" , "Tadeusz Struk" X-Mailer: aerc 0.18.2 References: In-Reply-To: On Tue Sep 10, 2024 at 5:30 PM EEST, Lukas Wunner wrote: > The ECDSA test vectors contain "params", "param_len" and "algo" elements > even though ecdsa.c doesn't make any use of them. The only algorithm > implementation using those elements is ecrdsa.c. I'm missing these pieces of information here at least: - akcipher.h tells that tail contains OID, parameter blob length and the blob itself. - akcipher.h leaves the size of those fields completely *undefined*. - According to call sites OID and blob length are 32-bit fields. - According to call sites that I bumped into they are always set to zero. - There's no information in the kernel source code that I could fine for any other rules how the should be set. =20 Putting random words (of which params_len is not even a word) to quotes does not really make this whole story obvious. You could just as well delete the paragraph, because that only makes you look for a struct that does not even exist. BR, Jarkko