From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD9F19AD48; Fri, 1 Nov 2024 09:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730452695; cv=none; b=GOcKe2WoO6cMIQgWbTgU83+4PlmKo8zq1v2Y8t9bLngQiBkmfLQHEdWDQzd5GA2CQiQx7hHK5SLt/Dji6ySXCJ7fo4WtlQyHRvHHrlj+F6SYfWG99fxWEfgrD3Z+tcfXC4pCMskKFGufIJMpUYmiaTsHNnsw+alFrZKfp96eGlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730452695; c=relaxed/simple; bh=VwuvobxN/JIIGvwQbzSNttNtS7UwYf45TGMjGF3SOJ0=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=u7fDZ/qqlv9gdCpnwl63h5SmJB09dH1YhTb2rt7RozXwME75WsQ9lJovFf4JHKeNj7CyKSAM/LVAbElVWzA7iGd4Iulayn6tupV7VB1vCc4d9b4x015EfH5Xy7ieZkJ6j+SgH1uOCW2JYu4pHYT+4DMR6hmb2gmJ2p/Oa9v6rjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d5qz6zlA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d5qz6zlA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E3E0C4CECD; Fri, 1 Nov 2024 09:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730452694; bh=VwuvobxN/JIIGvwQbzSNttNtS7UwYf45TGMjGF3SOJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d5qz6zlAZ/yf0UDelwHeivmWA7K7ngw7ePGaEXVLDbXRY77Sl87i9xABFv/CsbuR9 YQhJ9a2XQQEHXI+3qcl61MWwwXk3L3kIdwhGCjhl7n+fSXXaZ7GfTUDdNpXxQF/9TC wuvJkC7JPSrp9kZzDxhd9hT8DRVdjqs9Ifu9znfFyMHnswqPqhtNfQAxnU6qP+BtT1 1vlWWJdq11vYvvl+IhSSra8zkwWYV91Dx9pZ1/FvUvDK5sOp3dvnPWKNpqVUteIiaB DQ8E3XX+wB5GLYMdlvYmd4wFFbH/jW6QmaKUHoA3C8/RSFWU9xgKuZnkgoNU9sCYdZ QvFTh6pue4bQw== Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 01 Nov 2024 11:18:10 +0200 Message-Id: From: "Jarkko Sakkinen" To: "Ard Biesheuvel" Cc: "Thomas Gleixner" , "Ross Philipson" , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v11 00/20] x86: Trenchboot secure dynamic launch Linux kernel support X-Mailer: aerc 0.18.2 References: <20240913200517.3085794-1-ross.philipson@oracle.com> <87wmhoulb9.ffs@tglx> <87ldy3vpjh.ffs@tglx> In-Reply-To: On Fri Nov 1, 2024 at 10:50 AM EET, Ard Biesheuvel wrote: > On Fri, 1 Nov 2024 at 01:40, Jarkko Sakkinen wrote: > > > > On Fri Nov 1, 2024 at 2:33 AM EET, Jarkko Sakkinen wrote: > > > On Fri Nov 1, 2024 at 1:08 AM EET, Thomas Gleixner wrote: > > > > On Fri, Nov 01 2024 at 00:37, Jarkko Sakkinen wrote: > > > > > On Thu Oct 31, 2024 at 9:25 PM EET, Thomas Gleixner wrote: > > > > >> So this looks pretty reasonable to me by now and I'm inclined to= take it > > > > >> through the tip x86 tree, but that needs reviewed/acked-by's fro= m the > > > > >> crypto and TPM folks. EFI has been reviewed already. > > > > >> > > > > >> Can we make progress on this please? > > > > > > > > > > So TPM patches do have bunch of glitches: > > > > > > > > > > - 15/20: I don't get this. There is nothing to report unless tree > > > > > is falling. The reported-by tag literally meaningless. Maybe th= is > > > > > is something that makes sense with this feature. Explain from t= hat > > > > > angle. > > > > > - 16/20: Is this actually a bug fix? If it is should be before 15= /20. > > > > > - 17/20: the commit message could do a better job explaining how = the > > > > > locality can vary. I'm not sure how this will be used by rest o= f > > > > > the patch set. > > > > > - 18/20: I'm not confident we want to give privilege to set local= ity > > > > > to the user space. The commit message neither makes a case of t= his. > > > > > Has this been tested to together with bus encryption (just chec= king)? > > > > > > > > Can you please explicitely voice your detailed technical concerns i= n > > > > replies to the actual patches? > > > > > > - 15/20 looks like a rigged patch. I don't really know why it is done > > > so it is hard to either suggest how "resolve it". > > > - 16/20 probably makes sense but if it is a bug fix or part of it is, > > > the bug fix should have relevant fixes etc tags so that it can be > > > picked up to stable kernels. > > > - 17-18/20: I'd speak about this as the "one whole" i.e. here the > > > privilege to be able change locality during run-time is really > > > concerning. Could the locality be figured out for the kernel > > > command-line instead? The sysfs attribute can exist as read-only. > > > > > > So yeah, the way I see it 15-16 are the more trivial issue to sort > > > out (probably) but with 17-18 we have an actual architectural concern > > > for kernel overall. > > > > Further: > > > > 15/20: I can accept this without reported-by tag (or changed as > > suggested-by). It does not harm. > > 16/20: I'll re-review this with time. I'll try to get this done > > latest next week. > > > > So let's put focus only on 17 and 18. Can this problem be sorted out > > by kernel command-line parameter? In the case of locality we want to > > keep regular "chain of trust" i.e. boot-loader makes the decision, > > *even* in the case of DRTM. I would call this almost as constraint > > that would be wise to set. > > > > Please don't add a kernel command line parameter for this - the code > running in the decompressor will be the one setting it and there are > better ways to pass information between these components (and the > slaunch stack is already doing that in any case) Not sure if I follow this (I don't know what "decompressor" is). > Also, let's have this discussion in the appropriate place, i.e., on > the thread for each respective patch. Sure, I just did not have a lot of time to download the patch. BR, Jarkko