From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C254A1A; Fri, 22 Aug 2025 19:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755891079; cv=fail; b=oXUZnVHH+zFWA0ZUYPwtO02OjqVQeKo9ukyQHut2EYzYQu/lXV0RwgmYu8We7rujnLsd1Rwn+DFq8sYI4U1O7rnazA+CiJ1zIG0CvhQJLHUTsGGGbzW4NYRh8WnDXn6/5+i3643N2TfWL1GnyCiJYEzgT7tfouyUjvY+BO8zjqo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755891079; c=relaxed/simple; bh=A9clVWcAQKJnwV+R6evPQ3utHns8yhx/+Gsy1/UcAyM=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=QcVyUtrfMbUlkHJmpxaJ5LRQ+TWtDzhd/Gzq62c7XpQpg3E1Lp9Tnp48Bhu+8hY2d4n3bfx0ZFacb+jaUB1o140mT35xSddwuiyxH+jkSIlw/ocuFxzPjJxdEu9FboRSjyPZmSQgICms5DG6JWfIjSoBOXJPPvjj5z4PWedW2lY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h04nVnz6; arc=fail smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h04nVnz6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755891078; x=1787427078; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=A9clVWcAQKJnwV+R6evPQ3utHns8yhx/+Gsy1/UcAyM=; b=h04nVnz6zoXo3xCviOlWyZpUDCy3I6umLFRiiat2KI09LTbGRDcxK5GQ BiEMhVBL2lyw5t+FtJCGOBd/lD5Sc43sqGaCsftWLKDm43Y7nh+6WQ5Av b/GoEqc34OzJuAF03VgGBWnymzvui3Z1D1cEm2t8pMPBKXtfR33OOXgV5 AGD6iO8jCVi9MJsQZIOHvlbMc0pMchhNejHYSLCvlNwOKgQbImwIwKOYc l92iYGIv+rOSYdzCww/P4Vv8EVqc1Hl7sahOZWlRymMe9Gf91RvE4y/M3 9cQN4EO4mmOmFHVY6jO5lPUy5lWM0yxzYQfQMt9gAWtl2kWjtV1rQWLYl Q==; X-CSE-ConnectionGUID: OATXmv62S/ejq7IST7Hs0w== X-CSE-MsgGUID: 5Nw72txlT16IZaj3JPv4EQ== X-IronPort-AV: E=McAfee;i="6800,10657,11529"; a="57222550" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="57222550" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 12:31:16 -0700 X-CSE-ConnectionGUID: RBzr7ndrR2ycMrhbr+A2pw== X-CSE-MsgGUID: uVT2FEDOROeWfy++Q3WmwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="168288356" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 12:31:16 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 22 Aug 2025 12:31:16 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Fri, 22 Aug 2025 12:31:16 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (40.107.237.49) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 22 Aug 2025 12:31:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=czDGYL/w8yF3agQo7URJyRQbTYEm/Tw6Z66GxxaGFniAIoV5mLZ3an3LTb42lE5CRFMHndaxJESwqoj7grMe9xtSxQ1ezZr3pJpwlcPnn96p+heyrdGkSLarSoDULxrdNZ+Rjo+fu4BzTkWM06+3dFEMLaA6yF7tUMSkeH/eAz8Oo9QuSfXYwKy5+x0kKqYVIkzFsnuIlfvxN9RTwUQifa94R9WSRbdEVwGeziZj/2tBtahYfek+2AsNhVOtJVfxyV8JyZjvITdvg2OFYvhS4fSu9oDr8f/XfVdg63/7AwtZ3MQU+3HnHWE1OX4e4odiW7jC07mwygvLYy2BjDWs0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EogltnJsfrYws4jCg9kwgB9d8kK83skSPQ+wGLpSGfY=; b=idQRM/QQUJEsh8XMnOZm/knunL2utOmXMCJfhRAeRo2LtF3zMvg/X6tuAM67c12IN8ajWr6VXZKT+uYtbbfk/O9AyoTXWHcbQRLKYriPNbrYCHwWUP0NwY8mLObv1yjhWEgXGiZR+gfkK67h7J96H7nR/b4bVyKscidB55g7kPVV1X7ODf4yaPnqUVqkw8dtjal9yRL4eXGTBFgtHDGq8wqI/4ulImYQHoI/nsoSLbhkUcecy2/zfd78tIvQvACLl1Z+B4WxAk6Y9uhT3/AloPWy2pTHGBCdFp1ziY7RA8vtokK0QQPQOxjElx/+o/OSf4PHX2GWw6oXn5Ck9KU1Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB8121.namprd11.prod.outlook.com (2603:10b6:510:234::14) by DM6PR11MB4563.namprd11.prod.outlook.com (2603:10b6:5:28e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.15; Fri, 22 Aug 2025 19:31:12 +0000 Received: from PH7PR11MB8121.namprd11.prod.outlook.com ([fe80::ec4e:64cf:cf1f:daab]) by PH7PR11MB8121.namprd11.prod.outlook.com ([fe80::ec4e:64cf:cf1f:daab%7]) with mapi id 15.20.9052.017; Fri, 22 Aug 2025 19:31:11 +0000 From: "Sridhar, Kanchana P" To: Herbert Xu CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosry.ahmed@linux.dev" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ying.huang@linux.alibaba.com" , "akpm@linux-foundation.org" , "senozhatsky@chromium.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Gomes, Vinicius" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v11 18/24] crypto: acomp - Add crypto_acomp_batch_size() to get an algorithm's batch-size. Thread-Topic: [PATCH v11 18/24] crypto: acomp - Add crypto_acomp_batch_size() to get an algorithm's batch-size. Thread-Index: AQHcAp3rrlgug3tz+EGLnem5m/WFabRjRbuAgAvqfqA= Date: Fri, 22 Aug 2025 19:31:11 +0000 Message-ID: References: <20250801043642.8103-1-kanchana.p.sridhar@intel.com> <20250801043642.8103-19-kanchana.p.sridhar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB8121:EE_|DM6PR11MB4563:EE_ x-ms-office365-filtering-correlation-id: c4111a2f-c4b6-41df-f44e-08dde1b273c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?qT3gCF3jER/nM9wb4WgjybFt0QBM3YnMLaYh3hXrd9ACeF6UDWDS0ITL2cmU?= =?us-ascii?Q?30i57WICaJDDoADkW/BYLw8pwPneAK/ljH1OhOkmuVUNJyyqYen/xrstIg1n?= =?us-ascii?Q?kP0VP/nXByrxSjX0ACzeSAhRpr1Hz70UzRsDnmkwUuoCbqE50PRgqNhH5nKi?= =?us-ascii?Q?Zp60eB4xA5AhkmKtnjJ3CEA4u80jjv0UMWtAPOmtcF16Q2M7/Ma1QF6L0U5p?= =?us-ascii?Q?vEai0XdKQl4hzkmR8LraEgEx4ExN5yqeCbsBGp6qpcOV1vjmjt9Lut69SWkJ?= =?us-ascii?Q?wiIftvzYSoIjqVne3r64ybhH21PxTDTBi9ohTeoQrqZGrWvI7YOnniP2/zxS?= =?us-ascii?Q?CvWJo/YR7VeSAGDDuSVe0/DUM5nfX9kWl6Ufup2q3TQRMAXne93BpPCUIfy8?= =?us-ascii?Q?aC3TwUPVT6kOYWFnWr90N9TYp0AADqcFvvZnn5LxAd0amklquFbpF3cWjHaG?= =?us-ascii?Q?XZHX+nn/rChm3slBpUtNb4nUmnwRTWVjQcHXCD/R4B+gXIRJlwx5gl91IL82?= =?us-ascii?Q?a5+EmIbTQq331tThhz7IBL1qBIQrIWMf4E2DbOU20gGw3udhS58gkXLF6PPQ?= =?us-ascii?Q?uqDtL0H3+XJKOvaLgnQ4OIICoG5WNxPetPlPoaLBG8IaubZYwjm/QNbeYhYx?= =?us-ascii?Q?94tJOXITjwJXt9/YYw37C0iG08geGlTKwd3+iPlTIXBz4Yn67xi1NsbGEP2N?= =?us-ascii?Q?G6lfZrYA1wEIZLc1o9mLGqRgA/gMBO+AkhT8ZCLcDjuV6vWmW6uAmsUiavOh?= =?us-ascii?Q?6NLkCq26N1OTSaBh9rfGCdjXHwSZcOAIQ6+9Hk0Gleospobzy0yxZd/1OFsX?= =?us-ascii?Q?1baIucIcwTd+eK+odHbbg1iv7EWw6Ec15O8uDoy4RBtqWbKe/QYH9Z+wHw12?= =?us-ascii?Q?VeGAE259WP32/I0mULM5b447MVButwlHqgmg0o37F5HfKeF36vZlqMJP6O8k?= =?us-ascii?Q?C1kLWxS2spFpxXWRMMIIgIQqyWDkK/nFFYKPP861LDb+1UgKmxU+fW0wZzBS?= =?us-ascii?Q?RmZJNFmEofmgKQKCky2/fCMRkGFBDoETKNg2SozbbHr9X7Y4fYQYCV04b1EQ?= =?us-ascii?Q?d+Qoarkr5ZrPStqwKeuQVySSl5LncKg9MNzTevS7rb8dblZwFVcwn5FH/fOF?= =?us-ascii?Q?cAlujD07L4s+Ga1xx5e6wQywnUCpOpgLDUWL6iwS/gZTIkBlefXLldsXrDkJ?= =?us-ascii?Q?Dy54Q8oAIMK90mtTIOWYoU+7l5l81HtzavNCsXPFYzm/bj1u1dr9b8SI6jH/?= =?us-ascii?Q?oWti48Kzxuz9s7w03l5vB8bbVrc+DLJsb6Ky5mYGr5a/0j58GqJ32trRCmnB?= =?us-ascii?Q?Ds4AB9AxPIBLmSru76ObZWGIJaGC4jtkTy8CEQoK1smN/3VC16u4lvOy+pi6?= =?us-ascii?Q?A2BLER2kr28qnHjQmJYaf4mXDQCEePJi5lD2OMpBK49G6IDh0xcSk49Kd6BG?= =?us-ascii?Q?dklGNs1i7gM=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB8121.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mPn+QOPsKwNr8CJsbND1QZ+REL75knUtHGGeKv6CZnJqx6A+4GDl7GwCfHNG?= =?us-ascii?Q?ecOH+VsWtU79dNfHSPNV1e3ZiItU/ZMnytrSgOV2PrXT+ram35ESfN8HgdL0?= =?us-ascii?Q?SyWJ7WBXgiDIc7H1c+81Dq9g7UgprtzTsHjBMRf3RAwKbsKYHJ64rXuKbi85?= =?us-ascii?Q?025W53EhwUhPLYDvrEVo2WVDWG2b5b+ty92kEgwSeC0nfgGa2pQqCozapQnM?= =?us-ascii?Q?AfVThKHhz70vq4UBSeaBNf7qlnTZzdmhvpCkQ1hLodMHFMUZoZud0iMnp4q6?= =?us-ascii?Q?zFFvFTWbrvuIiT7grEskNqYhjr7Lu55ZI21fkD1mJsYFbkD8w1zxrh9G3zxO?= =?us-ascii?Q?0EmBDSXV+BSeEK57nAo90Ni2R9Egrf7ecKxBktrfJiz4NNXOrm9i6E9sS7uV?= =?us-ascii?Q?XT1fwfPF9KD8LDU7ASrrlcBi2f/1RrtOhZTmClEowgsbMOGsgnKLjSfSx7oG?= =?us-ascii?Q?StOsAd14Fy+stKYCP5paMiiV4rye6L2FRJoNSPasBAO4pmW4zfgihoUJDE9Z?= =?us-ascii?Q?A3GiZspryD96u9qZTjhvTwpwjT2SAfptTbRjIyG+7cq68QbYBHDnmzkKwPk2?= =?us-ascii?Q?pRfzRuVt5dVA1OcGkoDV64JcKG1zzqXCSJj8+T8hIH5Fw21S4dGFgcNtxlKj?= =?us-ascii?Q?Q8QSMNo//z/OX7NeFKEcAF+IklDW0t11LaRkF/6dFH4cZHiR1AkTmY44Y6+L?= =?us-ascii?Q?GMAwMCzsXpOKN3btmlMM0SQcheT2d2o61YmcgN6JI+sczS/Qh96a8NHjMRK0?= =?us-ascii?Q?U64uiwdtEy1qqi51h1EjiO4t57nSf4/5kVe/BzMauV5utl1aNgvRIpG/K0HG?= =?us-ascii?Q?aXxvsuQiOy4aizcdbhSp6nZw/LZ9K42e7pLSstrBDTuNvIvsPEl1mRTfcH71?= =?us-ascii?Q?ymoz2ZrsiOuN1EiFxGPAr4YIvfTDXaZENkMBIn0CfpUcUOSSOkEDcWnT0H3i?= =?us-ascii?Q?qypI4G7gZIjHpptwa7lWOAJvWAoEJAx7gdF931pmoZAqfJHt5lc4zjvsdY5k?= =?us-ascii?Q?FqUZlIkzp30ZRsuIx7e0qpTo6OOIYvds40ppvQUvF2RkdBx1m2GmiBw7xEF/?= =?us-ascii?Q?vrzfTXwVlh9W+QTeR1qA+Kpa6JjHlV+pQk6kwsGFaR8aDXrkUnoC3np+5hpG?= =?us-ascii?Q?DXXsiywjflatqqFx0v9odCF7Ksxr5rm73E0apVIiRDJqd9nrhdQYN3tyNwR8?= =?us-ascii?Q?fvCFN7twhuXDz5cs3cJd8y68pWXzL3BvJ2v38LH7j6YKXF9Cual7owhjlwNZ?= =?us-ascii?Q?x7F+XGy3z2aEo5Pk90OvYgaeYZCNOqeghv+XJVyOcMd3mIfW6wlLke58+Eel?= =?us-ascii?Q?PeIt/jph0mwjQAUMwUWjqwApvK3AakT7gA4w7jNwi6uZozNES5KiqTRN2lph?= =?us-ascii?Q?rbFziv6Ple72vprnj+KYMwUHBrWICd398iiREuUJxr50PnLYd6l8IL2cJSd5?= =?us-ascii?Q?itc9DLydyojPTsRWOK+lgPF9OS8kX3X3/+N73aYXt3OkYNPEgsOPthmX3KZz?= =?us-ascii?Q?GriOzKeEGre1D7J2V8IIRaiCSs+UCH+maNI0AvF6CsQh3cR/gnnSkEpHwTyr?= =?us-ascii?Q?qhBRZe4m5BG1W5KP8e/AcGaPPk9brvqyDqgIUqhrcApdRJu1hBa2nzgb3Q1Z?= =?us-ascii?Q?Jg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB8121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4111a2f-c4b6-41df-f44e-08dde1b273c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2025 19:31:11.8875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TNXNei5DRet0VjGDnf5pt8EJ5CBpJDqHXrLi1YnIFBJ77pEWIoLwbGH8zXg6Pl6bXo38HrCiL/Dekch5yWQwQeRarp7QozcjsIHU3RGg4lY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4563 X-OriginatorOrg: intel.com > -----Original Message----- > From: Herbert Xu > Sent: Thursday, August 14, 2025 10:29 PM > To: Sridhar, Kanchana P > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; yosry.ahmed@linux.dev; nphamcs@gmail.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; 21cnbao@gmail.com; > ying.huang@linux.alibaba.com; akpm@linux-foundation.org; > senozhatsky@chromium.org; linux-crypto@vger.kernel.org; > davem@davemloft.net; clabbe@baylibre.com; ardb@kernel.org; > ebiggers@google.com; surenb@google.com; Accardi, Kristen C > ; Gomes, Vinicius = ; > Feghali, Wajdi K ; Gopal, Vinodh > > Subject: Re: [PATCH v11 18/24] crypto: acomp - Add > crypto_acomp_batch_size() to get an algorithm's batch-size. >=20 > On Thu, Jul 31, 2025 at 09:36:36PM -0700, Kanchana P Sridhar wrote: > > > > diff --git a/include/crypto/internal/acompress.h > b/include/crypto/internal/acompress.h > > index ffffd88bbbad3..2325ee18e7a10 100644 > > --- a/include/crypto/internal/acompress.h > > +++ b/include/crypto/internal/acompress.h > > @@ -28,6 +28,8 @@ > > * > > * @compress: Function performs a compress operation > > * @decompress: Function performs a de-compress operation > > + * @get_batch_size: Maximum batch-size for batching > compress/decompress > > + * operations. > > * @init: Initialize the cryptographic transformation object. > > * This function is used to initialize the cryptographic > > * transformation object. This function is called only once at > > @@ -46,6 +48,7 @@ > > struct acomp_alg { > > int (*compress)(struct acomp_req *req); > > int (*decompress)(struct acomp_req *req); > > + unsigned int (*get_batch_size)(void); >=20 > I can't imagine a situation where this needs to be dynamic. > Please just make it a static value rather than a callback function. Hi Herbert, I am not sure I understand.. Kernel users such as zswap/zram need to query the algorithm to get the maximum supported batch-size so they can allocate resources for dst buffers. The get_batch_size() callback and associated crypto_acomp_batch_size() wrapper help accomplish this. Can you please clarify what you mean by "static value"? Thanks, Kanchana >=20 > Thanks, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt